[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Use QToolButton for Konsole
From: "Sascha Peilicke" <sasch.pe () gmx ! de>
Date: 2009-04-03 11:24:06
Message-ID: 20090403112406.20281.43992 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/509/
-----------------------------------------------------------
(Updated 2009-04-03 04:24:06.652947)
Review request for Konsole.
Summary
-------
here's a little patch that changes the two corner-widget buttons for new/close
tab functionality to use QToolButton instead of KPushButton. This way they use
less space and are more visually pleasant (see screenshots). A result of this
change is the immediate visibility of the new-tab button's menu. IMHO the
delayed menu of KPushButton is not really intuitive or even noticeable (to be
honest, I found that feature only in the code), now it's clear that the new-
button has some extra functionality if click-pressed. Last but not least
Konsole's tab-bar does now look the same as Konqueror's.
Diffs
-----
trunk/KDE/kdebase/apps/konsole/src/ViewContainer.h 941727
trunk/KDE/kdebase/apps/konsole/src/ViewContainer.cpp 941727
Diff: http://reviewboard.kde.org/r/509/diff
Testing
-------
Screenshots (updated)
-----------
Visual diff
http://reviewboard.kde.org/r/509/s/96/
Thanks,
Sascha
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic