[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] Review Request: Upgrade TerminalInterface to V2
From:       "Trever Fischer" <wm161 () wm161 ! net>
Date:       2009-03-31 12:15:54
Message-ID: 20090331121554.12755.41608 () localhost
[Download RAW message or body]



> On 2009-03-30 12:24:51, Trever Fischer wrote:
> > Just as a note, this patch breaks Yakuake on this line:
> > 
> > m_terminalInterface = qobject_cast<TerminalInterfaceV2*>(m_part);
> 
> Rahman Duran wrote:
> Did you also compiled the updated konsolePart?

Yup. Adding the non-V2 TerminalInterface to the list in Q_INTERFACES fixes this. My \
patch (http://reviewboard.kde.org/r/484/) has it.


- Trever


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/444/#review740
-----------------------------------------------------------


On 2009-03-28 15:58:08, Rahman Duran wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/444/
> -----------------------------------------------------------
> 
> (Updated 2009-03-28 15:58:08)
> 
> 
> Review request for kdelibs and Konsole.
> 
> 
> Summary
> -------
> 
> This is a new interface that extends the old ones functionality. 
> 
> 
> Diffs
> -----
> 
> trunk/KDE/kdelibs/interfaces/terminal/CMakeLists.txt 945618 
> trunk/KDE/kdelibs/interfaces/terminal/kde_terminal_interface_v2.h PRE-CREATION 
> 
> Diff: http://reviewboard.kde.org/r/444/diff
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Rahman
> 
> 

_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel


[prev in list] [next in list] [prev in thread] [next in thread]