[prev in list] [next in list] [prev in thread] [next in thread]
List: konsole-devel
Subject: Re: [Konsole-devel] Review Request: Fix Konsole part to work with
From: "Robert Knight" <robertknight () gmail ! com>
Date: 2009-03-31 8:42:29
Message-ID: 20090331084229.2700.50970 () localhost
[Download RAW message or body]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.kde.org/r/484/#review749
-----------------------------------------------------------
Ship it!
Please commit
- Robert
On 2009-03-30 13:59:43, Trever Fischer wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.kde.org/r/484/
> -----------------------------------------------------------
>
> (Updated 2009-03-30 13:59:43)
>
>
> Review request for Konsole.
>
>
> Summary
> -------
>
> The recent change to TerminalInterfaceV2 in konsole's KPart caused yakuake to stop \
> functioning properly. It would load up the KPart but when it got to \
> qobject_cast<TerminalInterface>() in the constructor, it failed to return a proper terminal \
> interface. This patch fixes it by making Qt take note that the KPart also implements \
> TerminalInterface in addition to TerminalInterfaceV2
>
> Diffs
> -----
>
> trunk/KDE/kdebase/apps/konsole/src/Part.h 947070
>
> Diff: http://reviewboard.kde.org/r/484/diff
>
>
> Testing
> -------
>
> After compiling this quick change, yakuake works again.
>
>
> Thanks,
>
> Trever
>
>
_______________________________________________
konsole-devel mailing list
konsole-devel@kde.org
https://mail.kde.org/mailman/listinfo/konsole-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic