[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    Re: [Konsole-devel] possibility to disable UTMP in Konsole
From:       Lubos Lunak <l.lunak () sh ! cvut ! cz>
Date:       2002-07-06 10:33:32
[Download RAW message or body]

On Friday 05 July 2002 21:30, Waldo Bastian wrote:
> On Tuesday 02 July 2002 12:22 pm, Lubos Lunak wrote:
> > - with utempter installed, UTMP entries are not correctly removed if
> > Konsole is running during KDE logout(*)
>
> Please try the following patch.
>
> Cheers,
> Waldo

 Yes, that fixes it. I had to change it a bit however because of kwrited 
(which doesn't start any process).

 Oh, and re:your comment on kde-cvs, I also don't like when 'who' prints 
zillions of lines :).

-- 
 Lubos Lunak
 l.lunak@email.cz ; l.lunak@kde.org
 http://dforce.sh.cvut.cz/~seli


["utmp.patch" (text/x-diff)]

--- TEPty.cpp.sav	Thu Jun 20 07:42:13 2002
+++ TEPty.cpp	Sat Jul  6 11:45:22 2002
@@ -246,6 +246,12 @@ void TEPty::setSize(int lines, int colum
   //kdDebug(1211)<<"TEPty::setSize() done"<<endl;
 }
 
+void TEPty::commClose()
+{
+  donePty();
+  KProcess::commClose();
+}
+
 void TEPty::donePty()
 {
   int status = exitStatus();
@@ -649,8 +655,6 @@ TEPty::TEPty() : pSendJobTimer(NULL)
   fd = openPty();
   connect(this, SIGNAL(receivedStdout(int, int &)), 
 	  this, SLOT(DataReceived(int, int&)));
-  connect(this, SIGNAL(processExited(KProcess *)),
-          this, SLOT(donePty()));
 }
 
 /*!
--- TEPty.h.sav	Thu Jun 20 07:42:13 2002
+++ TEPty.h	Sat Jul  6 11:46:49 2002
@@ -78,6 +78,7 @@ Q_OBJECT
     const char* deviceName();
     
   protected:
+      virtual void commClose();
       virtual int commSetupDoneC();
       virtual int setupCommunication(Communication comm);
   
--- kwrited.cpp.sav	Thu Jun 20 07:42:19 2002
+++ kwrited.cpp	Sat Jul  6 11:46:16 2002
@@ -55,8 +55,7 @@ KWrited::KWrited() : QObject()
 
 KWrited::~KWrited()
 {
-    pty->kill();
-    pty->donePty(); // this needs to be called manually here, because the app is exiting
+    pty->donePty();
     delete pty;
 }
 

_______________________________________________
konsole-devel mailing list
konsole-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread]