[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konsole-devel
Subject:    [Konsole-devel] Why konsole doesn't use KGlobalSettings::fixedFont()
From:       Takumi ASAKI <asataku () osk3 ! 3web ! ne ! jp>
Date:       2002-02-26 14:34:20
[Download RAW message or body]

Hi!

I wonder why konsole doesn't use KGlobalSettings::fixedFont().
I think it's more useful than QFont("fixed").

I wrote a patch to improve default font setting.
Please review it.

-- 
  Che Che - Bye Bye
        From: Takumi ASAKI <asataku@osk3.3web.ne.jp>
	URL: http://www3.osk.3web.ne.jp/~asataku/

["kdebase-3.0-cvs-konsole-defaultfont-20020225.diff" (text/x-diff)]

diff -ur kdebase.orig/konsole/konsole/konsole.cpp kdebase/konsole/konsole/konsole.cpp
--- kdebase.orig/konsole/konsole/konsole.cpp	Sun Feb 24 06:49:16 2002
+++ kdebase/konsole/konsole/konsole.cpp	Mon Feb 25 21:45:19 2002
@@ -109,6 +109,8 @@
 #include <kstringhandler.h>
 #include <ktip.h>
 
+#include <kglobalsettings.h>
+
 #include "konsole.h"
 #include <netwm.h>
 
@@ -853,15 +855,15 @@
    {
       n_defaultKeytab=config->readNumEntry("keytab",0); // act. the keytab for this session
       b_fullscreen = config->readBoolEntry("Fullscreen",FALSE);
-      n_defaultFont = n_font = QMIN(config->readUnsignedNumEntry("font",3),TOPFONT);
+      n_defaultFont = n_font = QMIN(config->readUnsignedNumEntry("font",DEFAULTFONT),TOPFONT);
       n_scroll   = QMIN(config->readUnsignedNumEntry("scrollbar",TEWidget::SCRRIGHT),2);
       n_bell = QMIN(config->readUnsignedNumEntry("bellmode",TEWidget::BELLSYSTEM),2);
 
       // Options that should be applied to all sessions /////////////
       // (1) set menu items and Konsole members
-      QFont tmpFont("fixed");
+      QFont tmpFont = KGlobalSettings::fixedFont();
       defaultFont = config->readFontEntry("defaultfont", &tmpFont);
-      setFont(QMIN(config->readUnsignedNumEntry("font",3),TOPFONT));
+      setFont(n_font);
 
       //set the schema
       s_kconfigSchema=config->readEntry("schema", "");
@@ -1071,7 +1073,7 @@
     f.setRawName( fonts[fontno] );
   else
   {
-    f.setFamily("fixed");
+    f = KGlobalSettings::fixedFont();
     f.setFixedPitch(true);
     f.setPixelSize(QString(fonts[fontno]).toInt());
   }

_______________________________________________
konsole-devel mailing list
konsole-devel@mail.kde.org
http://mail.kde.org/mailman/listinfo/konsole-devel

[prev in list] [next in list] [prev in thread] [next in thread]