[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-e
Subject:    Re: Double HTTP requests when URL is clicked on
From:       Simon Hausmann <hausmann () kde ! org>
Date:       2001-03-04 9:57:57
[Download RAW message or body]

On Mon, Feb 26, 2001 at 01:19:00PM +0000, Ben Blaukopf wrote:
> I've built Konq/QPE/QT for the iPaq, and when the browser does anything
> that involves clicking and retrieving a page (eg click on Home, click on
> a URL, click on a submit button) it sends two HTTP requests.
> 
> I'm fairly sure that I'm doing something odd in my build, but
> can't imagine what! Any hints gratefully appreciated, I really can't
> figure out what's going on here.

It isn't your fault at all :-) . It was a stupid kind of typo which made
the detach() call on the iojob in KRun slip into the wrong scope ;-)

The patch looks like this (to illustrate my stupidity when I wrote the code :)

@@ -84,11 +84,9 @@ void KRun::slotJobData( KIO::Job *job, c
     QBuffer buffer( data );
     buffer.open( IO_ReadOnly );
     if ( QImageIO::imageFormat( &buffer ) != 0 )
-    {
-       transferJob->detach( data );
-
        mtype = QString::fromLatin1( "image/*" ); // ###
-    }
+
+    transferJob->detach( data );
 
     job->disconnect( this, 0 );

And this fix is in the CVS Repository now.

Sorry for the trouble :-(

Bye,
 Simon 

[prev in list] [next in list] [prev in thread] [next in thread]