[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [konqueror] [Bug 352537] New: The Konqueror save file dialog cannot handle quotation marks in file n
From:       Jonathan M Davis <jmdavisProg () gmx ! com>
Date:       2015-09-10 22:29:32
Message-ID: bug-352537-5021 () http ! bugs ! kde ! org/
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=352537

            Bug ID: 352537
           Summary: The Konqueror save file dialog cannot handle quotation
                    marks in file names
           Product: konqueror
           Version: 4.14.3
          Platform: FreeBSD Ports
               URL: http://yande.re/post/show/303236
                OS: FreeBSD
            Status: UNCONFIRMED
          Severity: normal
          Priority: NOR
         Component: general
          Assignee: konq-bugs@kde.org
          Reporter: jmdavisProg@gmx.com

If I try and download a file via Konqueror, and it has one or more quotation
marks - " - in its name, then it does not work properly. If the file name has a
single quotation mark, then clicking on save does nothing, whereas if it has
two, then clicking on save results in the filename being only what's between
the quotation marks rather than the full filename with the quotation marks
embedded in it. If it has three quotation marks in it, the filename ends up
being what was between the first two quotation marks. And if four quotation
marks are used, then you get an error saying "You can only select one file." I
expect that more quotation marks will alternate between the behavior of giving
3 and 4 quotation marks, but I didn't test that. Interestingly enough, if I use
one or more single quotes, they work fine. It's just the double quotes that
fail.

So, clearly, however the file saving code is implemented for the save dialog in
Konqueror, it's interpreting the quotation marks in some manner as if a command
were being run in a shell rather than just saving the file. The only characters
that should be illegal in a filename on a *nix filesystem are / and \0.
Everything else should be legit and should end up in the filename verbatim if
it's put in the filename in the save dialog, and clearly that's not happening.

Reproducible: Always

Steps to Reproduce:
This should be testable by downloading any file and putting quotation marks in
its name, but if you go to this page:

http://yande.re/post/show/303236

and right click on the "Download larger version" link to select "Save link
as..." and then use that  save file dialog, you get a filename to try and save
that already has " in it. Similarly, if you go to this page

http://yande.re/post/show/330666

and right click on the "Download larger version" link to "Save link as..." you
get a filename to try and save that already has two " in it.

Actual Results:  
If the file name has a single " in it, then the save button does nothing,
whereas if it has two " in it, then the filename that ends up on disk is what
was between the quotes rather than the full filename that was provided. 3
quotation marks gives you what was between the first two quotes, and 4
quotation marks results in an error dialog popping up.

Expected Results:  
The resultant filename is exactly what was entered in the save file dialog,
even if it has special characters in it like a ".

-- 
You are receiving this mail because:
You are the assignee for the bug.
_______________________________________________
Konq-bugs mailing list
Konq-bugs@kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs

[prev in list] [next in list] [prev in thread] [next in thread]