[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 228697] [testcase] form's textarea size patch
From:       Germain Garand <germain () ebooksfrance ! org>
Date:       2010-02-28 3:41:36
Message-ID: 20100228034136.8DD4835A60 () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=228697


Germain Garand <germain@ebooksfrance.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |germain@ebooksfrance.org




--- Comment #3 from Germain Garand <germain ebooksfrance org>  2010-02-28 04:41:34 ---
hmmm, indeed the fudge factor on the horizontal axis looks acceptable. It would
be best though if it was as small as possible, as our textareas are already
bigger than in other UAs [*].
It seems 0.2 would be enough for me with all monospaced fonts, doesn't it for
you?

As for the vertical fudging, I'm not so sure the value is correct.
You testcase defines 5 rows, but then proceeds with a 6 rows default text (the
last being empty, but still existing because of the last newline before
</textarea>).
Other browsers do force vertical scrollbars at most sizes with such a default.

Besides, these:
-                (w->lineWrapMode() == QTextEdit::NoWrap ?
-                 w->horizontalScrollBar()->sizeHint().height()+lvs : 0)

are there to match the way MSIE sizes nowrap textareas
(I just verified this still work like this in ie7, with wine).
Is there a good reason to align our sizing on Mozilla when we are known to do
that MSIE-style since a decade?

[*]: most other UAs use a different, smaller setting for monospaced fonts. So
our textareas will use the same CSS settings (e.g. font-size: medium ) but
still look much larger.
There is half-implemented support for adding another set of sizes but it's not
finished (see css/cssstyleselector.cpp -> m_fixedFontSizes)

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs
[prev in list] [next in list] [prev in thread] [next in thread]