[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 191736] Twitter More button broken in Konqueror
From:       Germain Garand <germain () ebooksfrance ! org>
Date:       2010-01-31 5:59:37
Message-ID: 20100131055937.676A131EAB () immanuel ! kde ! org
[Download RAW message or body]

https://bugs.kde.org/show_bug.cgi?id=191736


Germain Garand <germain@ebooksfrance.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |germain@ebooksfrance.org




--- Comment #10 from Germain Garand <germain ebooksfrance org>  2010-01-31 06:59:34 ---
> Are you confident that the patch gets the captures exactly the same,

yes, very confident. I removed the handling of the one form that I coudn't find
a strict equivalent to, i.e (.|/s)* : "capture last char of zero or more" (I
think it is impossible to rewrite in an efficient form, but I may be missing
something)

you can see that substrings equivalence is already tested by the benchmark.

ironic thing is those piss poor regexp writters certainly did not intend to
capture the last character at all.

>  and that there isn't any escaping to consider or something?

ouch, no, you are right, the patch is broken in that respect... [(.|/s)+] will
be happily transformed. Will fix. Fortunately, we already have the parsing
logic for that so it should be less painful than poking one's eye out ^^;

> (And man, running this comparison benchmark on Opera 10.10 is hilarious).

Wow! indeed. Older versions did not show such dramatic differences.

-- 
Configure bugmail: https://bugs.kde.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs
[prev in list] [next in list] [prev in thread] [next in thread]