[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 93791] [test case] displays a table that appears to have empty
From:       Germain Garand <germain () ebooksfrance ! com>
Date:       2007-05-29 13:32:03
Message-ID: 20070529133203.12908.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=93791         




------- Additional Comments From germain ebooksfrance com  2007-05-29 15:32 -------
Le Dimanche 13 Mai 2007 21:01, Vincent Ricard a écrit :
> Hi,
> 
> I posted a new comment about #93791 :
> http://bugs.kde.org/show_bug.cgi?id=93791#c7
> 

Hi,
your analysis looks completely correct indeed.

> It seems 'RenderTable::columns' can be out of date after a table
> section removal (as with the testcase of the bug); and i wondered if
> someone can help me to fix that (just give me the process, i'll code
> it). Should we recompute 'columns' in the removeChildNode call 
> (at 
> which level? section? row? cell?) by looking through all tr's of all
> sections? by using the grid of each section?

yes, the column count should be recalculated after any node removal, but not right \
away as that would be costly and complicated. You would better use the delayed \
recalcSections/recalcCells mechanism. 

recalcSections is triggered whenever setNeedSectionRecalc or setNeedCellRecalc is \
set, so it's the best place I think. 

> by looking through all tr's of all
> sections? by using the grid of each section?

at the end of recalcSections, even though the grid will be sized based on the \
previous column count (which doesn't matter), it should be correctly populated, so \
simply counting all places where cellAt(x, y) is non-zero for each row and gathering \
the max result for all sections should be fine.

> 
> Any comments are welcomed (even to say my analysis is wrong :) )
> 
> Cheers,
> --
> Vincent Ricard
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs


[prev in list] [next in list] [prev in thread] [next in thread]