[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 111252] javascript onKeyUp does not work
From:       Germain Garand <germain () ebooksfrance ! com>
Date:       2005-11-04 8:18:22
Message-ID: 20051104081822.1288.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=111252         
germain ebooksfrance com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From germain ebooksfrance com  2005-11-04 09:18 -------
SVN commit 477527 by ggarand:

commit this fix since I have it around.
Only return when current key is access key's business

BUG: 111252



 M  +15 -8     khtmlview.cpp  


--- branches/KDE/3.5/kdelibs/khtml/khtmlview.cpp #477526:477527
 @ -1671,18 +1671,25  @
         if (d->scrollTimerId)
                 d->scrollSuspended = !d->scrollSuspended;
 
-    if (d->accessKeysEnabled) {
-    if (d->accessKeysPreActivate && _ke->key() != Key_Control) \
                d->accessKeysPreActivate=false;
-    if (_ke->key() == Key_Control &&  d->accessKeysPreActivate && _ke->state() == \
                Qt::ControlButton && !(KApplication::keyboardMouseState() & \
                Qt::ControlButton))
-	{
+    if (d->accessKeysEnabled) 
+    {
+        if (d->accessKeysPreActivate && _ke->key() != Key_Control) 
+            d->accessKeysPreActivate=false;
+        if (d->accessKeysPreActivate && _ke->state() == Qt::ControlButton && \
!(KApplication::keyboardMouseState() & Qt::ControlButton)) +        {
 	    displayAccessKeys();
 	    m_part->setStatusBarText(i18n("Access Keys \
activated"),KHTMLPart::BarOverrideText);  d->accessKeysActivated = true;
 	    d->accessKeysPreActivate = false;
-	}
-	else if (d->accessKeysActivated) accessKeysTimeout();
-        _ke->accept();
-        return;
+            _ke->accept();
+            return;
+        }
+	else if (d->accessKeysActivated) 
+        {
+            accessKeysTimeout();
+            _ke->accept();
+            return;
+        }
     }
 
     // Send keyup event
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs


[prev in list] [next in list] [prev in thread] [next in thread]