[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 75267] bad CSS render of  :hover with empty table cell "td"
From:       Leo Savernik <l.savernik () aon ! at>
Date:       2005-02-15 20:23:23
Message-ID: 20050215202323.1436.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=75267         
l.savernik aon at changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From l.savernik aon at  2005-02-15 21:23 -------
CVS commit by savernik: 

Fixed incomplete dynamic repainting of table backgrounds by including the
top and bottom extra space in the hit tests.

BUG: 75267


  M +5 -0      ChangeLog   1.381
  M +13 -0     rendering/render_table.cpp   1.273
  M +2 -0      rendering/render_table.h   1.112


--- kdelibs/khtml/ChangeLog  #1.380:1.381
 @ -1,2 +1,7  @
+2005-02-15  Leo Savernik  <l.savernik aon at>
+
+        * rendering/render_table.{cpp,h} (RenderCell::nodeAtPoint):
+        Including top and bottom extra space in hit testing.
+        
 2005-02-15  Allan Sandfeld Jensen <kde carewolf com>
 

--- kdelibs/khtml/rendering/render_table.cpp  #1.272:1.273
 @ -1946,4 +1946,17  @ void RenderTableCell::setStyle( RenderSt
 }
 
+bool RenderTableCell::nodeAtPoint(NodeInfo& info, int _x, int _y, int _tx, int _ty, \
HitTestAction hitTestAction, bool inside) +{
+  int tx = _tx + m_x;
+  int ty = _ty + m_y;
+
+  // also include the top and bottom extra space
+  inside |= style()->visibility() != HIDDEN
+      && (_y >= ty) && (_y < ty + height() + _topExtra + _bottomExtra)
+      && (_x >= tx) && (_x < tx + width());
+
+  return RenderBlock::nodeAtPoint(info, _x, _y, _tx, _ty, hitTestAction, inside);
+}
+
 // The following rules apply for resolving conflicts and figuring out which border
 // to use.

--- kdelibs/khtml/rendering/render_table.h  #1.111:1.112
 @ -388,4 +388,6  @ public:
     virtual short baselinePosition( bool = false ) const;
 
+    virtual bool nodeAtPoint(NodeInfo& info, int _x, int _y, int _tx, int _ty, \
HitTestAction hitTestAction, bool inside); +
     RenderTable *table() const { return static_cast<RenderTable \
                *>(parent()->parent()->parent()); }
     RenderTableSection *section() const { return static_cast<RenderTableSection \
*>(parent()->parent()); } _______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs


[prev in list] [next in list] [prev in thread] [next in thread]