[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 97897] [test case] table border does not update when content is
From:       Germain Garand <germain () ebooksfrance ! com>
Date:       2005-01-31 16:54:39
Message-ID: 20050131165439.29947.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=97897         
germain ebooksfrance com changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From germain ebooksfrance com  2005-01-31 17:54 -------
CVS commit by ggarand: 

don't forget to check table sections/rows for repaint

BUG: 97897, 97592


  M +2 -2      render_object.cpp   1.280
  M +7 -0      render_table.cpp   1.270


--- kdelibs/khtml/rendering/render_object.cpp  #1.279:1.280
 @ -1290,6 +1290,6  @ void RenderObject::dirtyFormattingContex
         return;        
     if (m_parent && (checkContainer || style()->width().isVariable() || \
                style()->height().isVariable() || 
-                     !(isFloatingOrPositioned() || flowAroundFloats() || \
                isTableCell() || hasOverflowClip())))
-        container()->dirtyFormattingContext(false);
+                     !(isFloating() || flowAroundFloats() || isTableCell())))
+        m_parent->dirtyFormattingContext(false);
 }
 

--- kdelibs/khtml/rendering/render_table.cpp  #1.269:1.270
 @ -1232,4 +1232,8  @ int RenderTableSection::layoutRows( int 
     int hspacing = table()->borderHSpacing();
     int vspacing = table()->borderVSpacing();
+    if (markedForRepaint()) {
+        repaintDuringLayout();
+        setMarkedForRepaint(false);
+    }                         
 
     if (toAdd && totalRows && (rowPos[totalRows] || !nextSibling())) {
 @ -1763,4 +1767,6  @ void RenderTableRow::layout()
             RenderTableCell *cell = static_cast<RenderTableCell *>(child);
             if ( child->needsLayout() ) {
+                if (markedForRepaint())
+                    cell->setMarkedForRepaint( true );
                 cell->calcVerticalMargins();
                 cell->layout();
 @ -1771,4 +1777,5  @ void RenderTableRow::layout()
         child = child->nextSibling();
     }
+    setMarkedForRepaint(false);
     setNeedsLayout(false);
 }
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs


[prev in list] [next in list] [prev in thread] [next in thread]