[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 96187] javascript (DOM exception 7) error returns a blank page
From:       David Faure <faure () kde ! org>
Date:       2005-01-31 13:50:05
Message-ID: 20050131135005.22936.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
         
http://bugs.kde.org/show_bug.cgi?id=96187         
faure kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|UNCONFIRMED                 |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From faure kde org  2005-01-31 14:50 -------
CVS commit by faure: 

setInnerHTML fix: check whether the contents will be allowed before deleting all children
BUG: 96187


  M +6 -1      html_elementimpl.cpp   1.184


--- kdelibs/khtml/html/html_elementimpl.cpp  #1.183:1.184
 @ -554,6 +554,11  @ bool HTMLElementImpl::setInnerHTML( cons
         return false;
 
-    removeChildren();
     int ec = 0;
+    // Make sure adding the new child is ok, before removing all children (#96187)
+    checkAddChild( fragment.handle(), ec);
+    if ( ec )
+        return false;
+
+    removeChildren();
     appendChild( fragment.handle(), ec );
     return !ec;
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs
[prev in list] [next in list] [prev in thread] [next in thread]