[prev in list] [next in list] [prev in thread] [next in thread] 

List:       konq-bugs
Subject:    [Bug 62296] dotted is displayed as dashed
From:       Dirk Mueller <mueller () kde ! org>
Date:       2004-03-01 3:06:01
Message-ID: 20040301030601.3514.qmail () ktown ! kde ! org
[Download RAW message or body]

------- You are receiving this mail because: -------
You are the assignee for the bug, or are watching the assignee.
      
http://bugs.kde.org/show_bug.cgi?id=62296      
mueller kde org changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|REOPENED                    |RESOLVED
         Resolution|                            |FIXED



------- Additional Comments From mueller kde org  2004-03-01 04:05 -------
CVS commit by mueller: 

alternative border-style: dotted implementation. Thanks for the performance
tester.

CCMAIL: 62296-done bugs kde org


  M +5 -0      ChangeLog   1.229
  M +5 -6      rendering/render_object.cpp   1.257


--- kdelibs/khtml/ChangeLog  #1.228:1.229
 @ -1,2 +1,7  @
+2004-03-01  Dirk Mueller  <mueller kde org>
+
+        * rendering/render_object.cpp (drawBorder): use drawPixel directly.
+        turns out to be more reliable and equally fast (#62296).
+
 2004-02-29  Dirk Mueller  <mueller kde org>
 

--- kdelibs/khtml/rendering/render_object.cpp  #1.256:1.257
 @ -561,17 +561,16  @ void RenderObject::drawBorder(QPainter *
         if ( width == 1 ) {
             // workaround Qt brokenness
-            p->setPen( QPen( Qt::NoPen ) );
-            p->setBrush( QBrush( c, Qt::Dense4Pattern ) );
-
+            p->setPen(QPen(c, width, Qt::SolidLine));
             switch(s) {
             case BSBottom:
             case BSTop:
-                p->drawRect(x1,y1,x2-x1,y2-y1);
+                for ( ; x1 < x2; x1 += 2 )
+                    p->drawPoint( x1, y1 );
                 break;
             case BSRight:
             case BSLeft:
-                p->drawRect(x1,y1,x2-x1,y2-y1);
+                for ( ; y1 < y2; y1 += 2 )
+                    p->drawPoint( x1, y1 );
             }
-
             break;
         }
_______________________________________________
Konq-bugs mailing list
Konq-bugs@mail.kde.org
https://mail.kde.org/mailman/listinfo/konq-bugs
[prev in list] [next in list] [prev in thread] [next in thread]