[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    minor kword fix
From:       Ulrich Kuettler <ulrich.kuettler () mailbox ! tu-dresden ! de>
Date:       2001-08-01 21:22:53
[Download RAW message or body]

Hi,

here's a little clean up for KWView::insertFormula. Could anyone please have 
a look at it and commit it if it's okey? I just don't know kword well enought 
to be certain.

I also played with the scroll timer in KWCanvas. It is started on mouse press 
now. Was there a reason you decided not to use it? You don't need a timer if 
you never start it, do you?

Uli

["kword-smallfix.patch" (text/x-diff)]

Index: kwcanvas.cc
===================================================================
RCS file: /home/kde/koffice/kword/kwcanvas.cc,v
retrieving revision 1.274
diff -u -3 -p -r1.274 kwcanvas.cc
--- kwcanvas.cc	2001/07/30 14:15:21	1.274
+++ kwcanvas.cc	2001/08/01 21:21:48
@@ -486,6 +486,7 @@ void KWCanvas::contentsMousePressEvent( 
                     emit currentFrameSetEditChanged();
                  emit updateRuler();
             }
+            m_scrollTimer->start( 50 );
         }
         break;
         case MM_CREATE_TEXT: case MM_CREATE_PART: case MM_CREATE_TABLE:
@@ -959,7 +960,7 @@ void KWCanvas::contentsMouseMoveEvent( Q
     KoPoint docPoint = m_doc->unzoomPoint( normalPoint );
     if ( m_mousePressed ) {
 
-	doAutoScroll();
+	//doAutoScroll();
 
         switch ( m_mouseMode ) {
             case MM_EDIT:
Index: kwview.cc
===================================================================
RCS file: /home/kde/koffice/kword/kwview.cc,v
retrieving revision 1.360
diff -u -3 -p -r1.360 kwview.cc
--- kwview.cc	2001/08/01 09:13:55	1.360
+++ kwview.cc	2001/08/01 21:21:59
@@ -2269,9 +2269,11 @@ void KWView::insertFormula()
         frameset->finalize(); // done last since it triggers a redraw
 
         // Strange, seems we need this - hmm, do we, still ?
-        edit->getCursor()->parag()->invalidate( 0 ); // and that's done by \
                KWTextParag::setCustomItem. Hmm.
-        edit->getCursor()->parag()->setChanged( true );
-        m_doc->slotRepaintChanged( edit->frameSet() );
+        // There was a bug in KWFormulaFrameSet::slotFormulaChanged that could
+        // have been the cause of this. Maybe we don't need this any longer.
+        //edit->getCursor()->parag()->invalidate( 0 ); // and that's done by \
KWTextParag::setCustomItem. Hmm. +        //edit->getCursor()->parag()->setChanged( \
true ); +        //m_doc->slotRepaintChanged( edit->frameSet() );
         m_doc->refreshDocStructure(FT_FORMULA);
     }
 }


_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]