[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KPresenter (Auto Presentation wait time)
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-07-31 13:17:29
[Download RAW message or body]

On Tuesday 31 July 2001 11:07, Toshitaka Fujioka wrote:
> I think that very good idea!! 
> I remade a patch. Please review.

I think the QTimer * is dangerous.
How do you make sure you're not creating it multiple times ?
At least if you want to keep it "built on demand", add a check to see
if it's not != 0 already.
Or just use a QTimer member variable (no pointer), that would be simpler.

Also, why change the interval to a huge number, e.g. one day ? You can stop the timer, instead.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]