[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Bug fix Patch for KPresenter
From:       Lukas Tinkl <lukas () kde ! org>
Date:       2001-07-22 9:15:38
[Download RAW message or body]

Dne ne 22. červenec 2001 06:40 David Faure napsal(a):
> On Fri, Jul 20, 2001 at 10:52:21PM +0900, Toshitaka Fujioka wrote:
> > > Indeed. Hmm. Too bad that this whole "loading a page" thing is so much
> > > of a hack. Maybe a better patch would be to disable the loading of
> > > those values when onlyPage (or whatever it's called) isn't -1 ?
> > > Oh, your patch doesn't even do that - so I guess it breaks loading
> > > those values when loading a normal document ! You should restore the
> > > values only if we're in the "load a single page" case. But I think it
> > > would be even better to simply skip loading the values in that case -
> > > as we already do for other things, like the selected pages list.
> >
> > Hmm, I have a one idea.
> > I store "Horizontal Raster", "Vertical Raster", "Background color
> > (editing mode)",  "Infinite Loop", "Manual switch to next step" and
> > "Speed of the presentation" to KPresenterFactory::global()->config() not
> > to store it to *.kpr file. Because I think that many users don't need to
> > change these.
> >
> > Of course "Infinite Loop", "Manual switch to next step" and "Speed of the
> > mode)" move to "Configure KPresenter". (patch is 90% complete)
> >
> > 1.1 applies this patch and I eliminate this part after release 1.1.
> > How do you think ?
>
> Hmm, this is a different issue :) ... Do we want that ?
> Doesn't the "manual or automated" and the "presentation speed" depend
> on the actual presentation ? I would say so.
>
> I don't know what the rasters are... ah, the grid ? We should rename
> that after 1.1 (I think KWord says grid now, raster is Reggie's own
> translation AFAIK :). Hmm, dunno about those.
>
> Colors are very presentation-dependent too....
>
> So I don't think it's a good idea to move those settings to the
> application config file, but that's just my opinion and I'd love to
> see more opinions about those patches on this list... :}

So here's my opinion: agreed :)
Yes, I think as well that these settings are presentation-dependent.

-- 
Lukas Tinkl | lukas@kde.org
KDE i18n maintainer
http://www.kde.org/international/czechia
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]