[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Bug fix Patch for KPresenter
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-07-19 12:11:40
[Download RAW message or body]

On Thursday 19 July 2001 15:03, Toshitaka Fujioka wrote:
> Hello,
> 
> The attached patch fixes a bug.

Hi. Can you add "-p" to your options for cvs diff ? Makes it easier to see in 
which method the changes are.

> koffice-kpresenter-bugfix-initializationOfVariable-20010719.diff:
> Variable ("Infinite Loop", "Manual switch to next step", 
> "Speed of the presentation") fixes a bug changed in value of default
> when I inserted a new page.

Indeed. Hmm. Too bad that this whole "loading a page" thing is so much of a hack.
Maybe a better patch would be to disable the loading of those values when
onlyPage (or whatever it's called) isn't -1 ?
Oh, your patch doesn't even do that - so I guess it breaks loading those values
when loading a normal document ! You should restore the values only if we're
in the "load a single page" case. But I think it would be even better to simply
skip loading the values in that case - as we already do for other things, like
the selected pages list.

> koffice-kpresenter-bugfix-reflectColorInToolBar-20010719.diff:
> I let "TK... icon" reflect current Text Color, Pen Color and Brush Color.

Thanks !
Why the hardcoded black and white in some places though ?
People use other color schemes, and for them black and white are wrong :)
But that's a minor issue compared to the bugfix this is about, though.

> koffice-kpresenter-bugfix-screenPresentation-20010719.diff:
> I fix the bug that the right and left button of mouse does not work
> with Screen Presentation (besides first page).

Ohh, good one, apply please :)

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]