From koffice-devel Thu Jun 28 13:27:16 2001 From: Toshitaka Fujioka Date: Thu, 28 Jun 2001 13:27:16 +0000 To: koffice-devel Subject: Re: QList::at and so on :} X-MARC-Message: https://marc.info/?l=koffice-devel&m=99374185522521 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--------------Boundary-00=_GP6NMP2HO98NI7E8G588" --------------Boundary-00=_GP6NMP2HO98NI7E8G588 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8bit On Thursday 28 June 2001 08:32, David Faure wrote: > On Thursday 28 June 2001 00:43, Toshitaka Fujioka wrote: > > Thank you for advice. I remade patch. > > Please review. > > - objectList()->remove( i ); > + objectList()->remove( kpobject ); > > Hmm, this is actually slower. Instead of removing the item number i, > it's going to have to look for kpobject from the scratch ! Ah, I see. Thank you for advice. > Using a real iterator would be better, because you can remove the item > directly using it. I remade patch. Is this OK ? Thank you. -- Toshitaka Fujioka http://www.kde.org The K Desktop Environment Project fujioka@kde.org http://www.kde.gr.jp Japan KDE User's Group toshitaka@kde.gr.jp -- We offer the best Desktop Environment to you. (This is my goal. ;-)) -- --------------Boundary-00=_GP6NMP2HO98NI7E8G588 Content-Type: text/x-diff; charset="iso-8859-1"; name="koffice-kpresenter-fix-qlist-20010628.diff" Content-Transfer-Encoding: base64 Content-Disposition: attachment; filename="koffice-kpresenter-fix-qlist-20010628.diff" ZGlmZiAtdXIga29mZmljZS5vcmlnL2twcmVzZW50ZXIvcGFnZS5jYyBrb2ZmaWNlL2twcmVzZW50 ZXIvcGFnZS5jYwotLS0ga29mZmljZS5vcmlnL2twcmVzZW50ZXIvcGFnZS5jYwlUaHUgSnVuIDI4 IDAxOjA0OjAzIDIwMDEKKysrIGtvZmZpY2Uva3ByZXNlbnRlci9wYWdlLmNjCVRodSBKdW4gMjgg MjI6MDQ6MzcgMjAwMQpAQCAtMTA5LDcgKzEwOSw3IEBACiAgICAgICAgIHJhdGlvID0gMDsKICAg ICAgICAga2VlcFJhdGlvID0gZmFsc2U7CiAgICAgICAgIG1vdXNlU2VsZWN0ZWRPYmplY3QgPSBm YWxzZTsKLSAgICAgICAgc2VsZWN0ZWRPYmplY3ROdW1iZXIgPSAtMTsKKyAgICAgICAgc2VsZWN0 ZWRPYmplY3RQb3NpdGlvbiA9IC0xOwogICAgIH0gZWxzZSB7CiAgICAgICAgIHZpZXcgPSAwOwog ICAgICAgICBoaWRlKCk7CkBAIC0xMjk2LDkgKzEyOTYsOSBAQAogICAgIGlmKHZpZXctPmtQcmVz ZW50ZXJEb2MoKS0+bnVtU2VsZWN0ZWQoKT09MCkKICAgICAgICAgcmV0dXJuOwogCi0gICAgaWYg KCAhdmlldy0+a1ByZXNlbnRlckRvYygpLT5yYWlzZUFuZExvd2VyT2JqZWN0ICYmIHNlbGVjdGVk T2JqZWN0TnVtYmVyICE9IC0xICkgeworICAgIGlmICggIXZpZXctPmtQcmVzZW50ZXJEb2MoKS0+ cmFpc2VBbmRMb3dlck9iamVjdCAmJiBzZWxlY3RlZE9iamVjdFBvc2l0aW9uICE9IC0xICkgewog ICAgICAgICBsb3dlck9iamVjdCgpOwotICAgICAgICBzZWxlY3RlZE9iamVjdE51bWJlciA9IC0x OworICAgICAgICBzZWxlY3RlZE9iamVjdFBvc2l0aW9uID0gLTE7CiAgICAgfQogICAgIGVsc2UK ICAgICAgICAgdmlldy0+a1ByZXNlbnRlckRvYygpLT5yYWlzZUFuZExvd2VyT2JqZWN0ID0gZmFs c2U7CkBAIC00MzY4LDQ0ICs0MzY4LDMyIEBACiAKIHZvaWQgUGFnZTo6cmFpc2VPYmplY3QoKQog ewotICAgIGlmICggc2VsZWN0ZWRPYmplY3ROdW1iZXIgPT0gLTEgKSB7Ci0gICAgICAgIEtQT2Jq ZWN0ICprcG9iamVjdCA9IDA7Ci0gICAgICAgIGludCBqID0gMDsKLSAgICAgICAgLy8gRXhhbWlu ZSBudW1iZXIgb2YgdGhlIG9iamVjdCB3aGljaCB1c2VyIHNlbGVjdGVkLgotICAgICAgICBmb3Ig KCB1aW50IGkgPSAwOyBpIDwgb2JqZWN0TGlzdCgpLT5jb3VudCgpOyArK2kgKSB7Ci0gICAgICAg ICAgICBrcG9iamVjdCA9IG9iamVjdExpc3QoKS0+YXQoIGkgKTsKLSAgICAgICAgICAgIGlmICgg a3BvYmplY3QtPmlzU2VsZWN0ZWQoKSApIHsKLSAgICAgICAgICAgICAgICArK2o7Ci0gICAgICAg ICAgICAgICAgaWYgKCBqID4gMSApCi0gICAgICAgICAgICAgICAgICAgIGJyZWFrOwotICAgICAg ICAgICAgfQotICAgICAgICB9CisgICAgaWYgKCBzZWxlY3RlZE9iamVjdFBvc2l0aW9uID09IC0x ICkgeworICAgICAgICBLUE9iamVjdCAqa3BvYmplY3Q7CiAKLSAgICAgICAgaWYgKCBqID09IDEg KSB7IC8vIGV4ZWN1dGUgdGhpcyBpZiB1c2VyIHNlbGVjdGVkIGlzIG9uZSBvYmplY3QuCi0gICAg ICAgICAgICBmb3IgKCB1aW50IGkgPSAwOyBpIDwgb2JqZWN0TGlzdCgpLT5jb3VudCgpOyArK2kg KSB7Ci0gICAgICAgICAgICAgICAga3BvYmplY3QgPSBvYmplY3RMaXN0KCktPmF0KCBpICk7Cisg ICAgICAgIGlmICggdmlldy0+a1ByZXNlbnRlckRvYygpLT5udW1TZWxlY3RlZCgpID09IDEgKSB7 IC8vIGV4ZWN1dGUgdGhpcyBpZiB1c2VyIHNlbGVjdGVkIGlzIG9uZSBvYmplY3QuCisgICAgICAg ICAgICBmb3IgKCBrcG9iamVjdCA9IG9iamVjdExpc3QoKS0+Zmlyc3QoKTsga3BvYmplY3QgIT0g MDsga3BvYmplY3QgPSBvYmplY3RMaXN0KCktPm5leHQoKSApIHsKICAgICAgICAgICAgICAgICBp ZiAoIGtwb2JqZWN0LT5pc1NlbGVjdGVkKCkgKSB7Ci0gICAgICAgICAgICAgICAgICAgIG9iamVj dExpc3QoKS0+cmVtb3ZlKCBpICk7CisgICAgICAgICAgICAgICAgICAgIHNlbGVjdGVkT2JqZWN0 UG9zaXRpb24gPSBvYmplY3RMaXN0KCktPmF0KCk7CisgICAgICAgICAgICAgICAgICAgIG9iamVj dExpc3QoKS0+cmVtb3ZlKCBzZWxlY3RlZE9iamVjdFBvc2l0aW9uICk7CiAgICAgICAgICAgICAg ICAgICAgIG9iamVjdExpc3QoKS0+YXBwZW5kKCBrcG9iamVjdCApOwotICAgICAgICAgICAgICAg ICAgICBzZWxlY3RlZE9iamVjdE51bWJlciA9IGk7CiAgICAgICAgICAgICAgICAgICAgIGJyZWFr OwogICAgICAgICAgICAgICAgIH0KICAgICAgICAgICAgIH0KICAgICAgICAgfQogICAgICAgICBl bHNlCi0gICAgICAgICAgICBzZWxlY3RlZE9iamVjdE51bWJlciA9IC0xOworICAgICAgICAgICAg c2VsZWN0ZWRPYmplY3RQb3NpdGlvbiA9IC0xOwogICAgIH0KIH0KIAogdm9pZCBQYWdlOjpsb3dl ck9iamVjdCgpCiB7Ci0gICAgS1BPYmplY3QgKmtwb2JqZWN0ID0gMDsKKyAgICBLUE9iamVjdCAq a3BvYmplY3Q7CiAKLSAgICBmb3IgKCB1aW50IGkgPSAwOyBpIDwgb2JqZWN0TGlzdCgpLT5jb3Vu dCgpOyArK2kgKSB7Ci0gICAgICAgIGtwb2JqZWN0ID0gb2JqZWN0TGlzdCgpLT5hdCggaSApOwor ICAgIGZvciAoIGtwb2JqZWN0ID0gb2JqZWN0TGlzdCgpLT5maXJzdCgpOyBrcG9iamVjdCAhPSAw OyBrcG9iamVjdCA9IG9iamVjdExpc3QoKS0+bmV4dCgpICkgewogICAgICAgICBpZiAoIGtwb2Jq ZWN0LT5pc1NlbGVjdGVkKCkgKSB7Ci0gICAgICAgICAgICBvYmplY3RMaXN0KCktPnJlbW92ZSgg aSApOwotICAgICAgICAgICAgb2JqZWN0TGlzdCgpLT5pbnNlcnQoIHNlbGVjdGVkT2JqZWN0TnVt YmVyLCBrcG9iamVjdCApOworICAgICAgICAgICAgb2JqZWN0TGlzdCgpLT5yZW1vdmUoIG9iamVj dExpc3QoKS0+YXQoKSApOworICAgICAgICAgICAgb2JqZWN0TGlzdCgpLT5pbnNlcnQoIHNlbGVj dGVkT2JqZWN0UG9zaXRpb24sIGtwb2JqZWN0ICk7CiAgICAgICAgICAgICBicmVhazsKICAgICAg ICAgfQogICAgIH0KZGlmZiAtdXIga29mZmljZS5vcmlnL2twcmVzZW50ZXIvcGFnZS5oIGtvZmZp Y2Uva3ByZXNlbnRlci9wYWdlLmgKLS0tIGtvZmZpY2Uub3JpZy9rcHJlc2VudGVyL3BhZ2UuaAlU aHUgSnVuIDI4IDAxOjA0OjAzIDIwMDEKKysrIGtvZmZpY2Uva3ByZXNlbnRlci9wYWdlLmgJVGh1 IEp1biAyOCAyMjowNjo1NyAyMDAxCkBAIC0yNzAsNyArMjcwLDcgQEAKIAogICAgIHZvaWQgcmFp c2VPYmplY3QoKTsKICAgICB2b2lkIGxvd2VyT2JqZWN0KCk7Ci0gICAgaW50IHNlbGVjdGVkT2Jq ZWN0TnVtYmVyOworICAgIGludCBzZWxlY3RlZE9iamVjdFBvc2l0aW9uOwogCiBwdWJsaWMgc2xv dHM6CiAgICAgdm9pZCBjaFBpYygpOwo= --------------Boundary-00=_GP6NMP2HO98NI7E8G588-- _______________________________________________ Koffice-devel mailing list Koffice-devel@master.kde.org http://master.kde.org/mailman/listinfo/koffice-devel