From koffice-devel Fri Jun 22 19:38:46 2001 From: David Faure Date: Fri, 22 Jun 2001 19:38:46 +0000 To: koffice-devel Subject: Re: Patch for KPresenter (progress bar of "Select All") X-MARC-Message: https://marc.info/?l=koffice-devel&m=99324238729925 On Friday 22 June 2001 13:08, Lukas Tinkl wrote: > Dne pá 22. červen 2001 11:39 David Faure napsal(a): > > > On Friday 22 June 2001 05:45, Toshitaka Fujioka wrote: > > > Hello, > > > > > > This patch displays progress bar when user executed "Select All". > > > (Werner listed this.) > > > > > > Please review. > > > > Very cool. > > > > Just nitpicking (as usual) : > > for ( int i = 0; i <= static_cast( objectList()->count() ); i++ ) > > { is written simpler as > > for ( uint i = 0; i <= objectList()->count(); i++ ) { > > > > Also, this patch adds a i18n( "Selecting..." ) which breaks the message > > freeze (unless kpresenter already has such a message somewhere else). > > Well, for one string that doesn't appear very long you might get away with > > it ;-) > > > > Oh, and > > + if ( progress.wasCancelled() ) > > + break; > > This means that if I press Cancel, half of the objects will still be > > selected. I'm afraid you have to unselect the objects when cancel is > > pressed ? Then you need a progress bar for doing that, which has cancel > > too, etc. LOL :)))) In fact here it might be a good idea NOT to have cancel > > (after all, unselecting all objects is as simple as clicking somewhere). > > Can QProgressDialog not have a cancel button ? Not sure. > > from page.cc: > > void Page::deSelectAllObj() Yes, and ? If it takes a long time to select them all (needing a progress dialog), doesn't it take the same time to deselect them all ? -- David FAURE, david@mandrakesoft.com, faure@kde.org http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/ KDE, Making The Future of Computing Available Today _______________________________________________ Koffice-devel mailing list Koffice-devel@master.kde.org http://master.kde.org/mailman/listinfo/koffice-devel