[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KPresenter (Undo and Redo with Text Object)
From:       Reginald Stadlbauer <reggie () trolltech ! com>
Date:       2001-05-24 13:23:57
[Download RAW message or body]

On Thursday 24 May 2001 15:18, Werner Trobin wrote:
> David Faure wrote:
> > On Thursday 24 May 2001 14:28, Werner Trobin wrote:
> > > David Faure wrote:
> > > > On Thursday 24 May 2001 08:11, Werner Trobin wrote:
> > > > > Toshitaka Fujioka wrote:
> > > > > > On Tuesday 22 May 2001 19:44, Toshitaka Fujioka wrote:
> > > > > > [snip]
> > > > > >
> > > > > > > 2. Crash assumes that I execute Redo after I select it more
> > > > > > > than one character, and pushed Del or Back Space or Ctrl+X key.
> > > > > > > (Even if this problem doesn't apply a patch, it is generated.)
> > > > > >
> > > > > > Sorry, it is not Redo. It is Undo.
> > > > >
> > > > > I'm sorry, but I don't have the time right now (exams,
> > > > > projects,...). Anyone?
> > > >
> > > > Hmm, ok, but you wrote this undo/redo integration (between the
> > > > text-object and kpresenter's global history). Does the patch look
> > > > sensible at first sight (i.e. not necessarily testing it) ?
> > >
> > > The problem I see is that it manipulates the local text object
> > > history and not the global one. I didn't test it, but I can
> > > imagine that some commands are undone and still are "scheduled
> > > for undo" in the global history.
> >
> > I see.
> >
> > > The connection between those histories is really simple: Every time
> > > a text object creates a command for its history we store a fake
> > > command in the global history. If we undo that one, we forward the
> > > undo request to the local history. Period. This will get out of
> > > sync with this patch :}
> >
> > Yes, that's exactly how I did it in KWord too.
> > If the problem is with "redo" only, doesn't that mean that you forgot to
> > do the same with redo ?
>
> Huh? The fake action just forwards undo and redo. If the command
> is inserted once it should work all the time. Sorry, but I don't
> get your question. One possibility is that undo/redo itself is
> broken in this very early version of QRT :}

That sounds very possible, as I rewrote the whole undo/redo system after than 
(because it was not flexible enough to do undo/redo of formats, etc.)

-- 
Reggie (reggie@trolltech.com)
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]