[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Patch for KPresenter (Rename page title )
From:       Toshitaka Fujioka <toshitaka () kde ! gr ! jp>
Date:       2001-05-05 11:12:01
[Download RAW message or body]

On Friday 04 May 2001 01:00, Toshitaka Fujioka wrote:
> On Thursday 03 May 2001 09:17, David Faure wrote:
> > On Wednesday 02 May 2001 17:26, Toshitaka Fujioka wrote:
> > > On Wednesday 02 May 2001 21:00, David Faure wrote:
> > > > On Wednesday 02 May 2001 10:56, Toshitaka Fujioka wrote:
> > > > > On Wednesday 02 May 2001 07:36, David Faure wrote:
> > > > > > It seems to me that the new lists in the document (titles and
> > > > > > bools) will not get updated when removing/adding/moving pages.
> > > > > > What about storing this information inside the sidebar item
> > > > > > instead ? Those get updated appropriately when moving pages iirc.
> > > > >
> > > > > I update in void KPresenterDoc::pageTitleInsertOrDelete( ... ).
> > > >
> > > > Ah yes, about that one.... :)
> > > > Why not make two separate methods, one for insert and one for delete
> > > > ? They don't seem to share any common code anyway.
> > >
> > > Changed.
> > > Thank you for your advice. I remade patch.
> > > Please review. ;-)
> >
> > What's savePageTitle for ? It seems to insert the title of the page
> > when using "Copy page" or "Duplicate Page"... but if pasting to another
> > document, that won't work. Would be better to save it as part of the XML.
>
> This part is not a problem. There seems to be problem on other parts.
> For example:
> page 1  title: a <- rename
> page 2  title: b <- rename
> page 3  title: c <- rename
>
> Copy Page page 3
> I do paste in KPresenter which I embedded in KSpread.
> I save afterwards. I extraction file and try to watch contents.
> contents:
> -----------------
>  <PAGE_TITLE>
>   <Title title="" />
>   <Title title="a" />
>  </PAGE_TITLE>
> -----------------
> I try to look for where is a problem.

I'm sorry, I did not understand intention of your question.
"savePageTitle" saves a title of a page to copy temporarily.
I don't store this part in XML. 
It is "QDomElement KPresenterDoc::saveTitle( QDomDocument &doc )" that
save page title in XML.

"savePageTitle" rename "saveCurrentPageTitle".

I attaced patch. (CVS of 05/05)
If a patch is wrong, please advise.

Thank you.

 
["koffice-kpresenter-newfeature2-20010506.diff.tar.gz" (application/x-gzip)]
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel


[prev in list] [next in list] [prev in thread] [next in thread]