[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: BIC issue in kspell
From:       Laurent Montel <lmontel () mandrakesoft ! com>
Date:       2001-02-12 10:26:48
[Download RAW message or body]

Le Lundi 12 Février 2001 10:11, Simon Hausmann a écrit :
> On Mon, Feb 12, 2001 at 10:55:32AM +0000, Laurent Montel wrote:
> > Le Lundi 12 Février 2001 09:29, Werner Trobin a écrit :
> > > Hi!
> > >
> > > Laurent changed a static member in kspell and IMHO this is
> > > a BIC change.
> > >
> > > Comments?
> >
> > Hi, Werner
> >
> > I just change this function :
> >
> > int
> > KSpell::modalCheck( QString& text, KSpellConfig* _kcs )
> >
> > this static function is just used by kspread (tools/spell)
> > I changed it to allow to used local kspell config in kspread.
> > Because in kspread now you can change locally spell language.
> > So kspread doesn't modify global spell.
>
> This change is indeed binary incompatible, as the function signature
> changed. (...talking about reviewed patches... ;-)

Yes it's right, but this function is just used by kspread.

>
> How about having two methods:
>
> int modalCheck( QString &text ) // marked as deprecated
>
> and
>
> int modalCheck( QString &text, KSpellConfig *_kcs )


So I can write this two function, if you want, no problem.

bye

>
> Bye,
>  Simon
> _______________________________________________
> Koffice-devel mailing list
> Koffice-devel@master.kde.org
> http://master.kde.org/mailman/listinfo/koffice-devel
_______________________________________________
Koffice-devel mailing list
Koffice-devel@master.kde.org
http://master.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]