'Re: Review Request 104252: Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request 104252: Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2013-02-07 21:25:31
Message-ID: 20130207212531.5857.68481 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/104252/#review26897
-----------------------------------------------------------

I see this has a ship it but marked as uncommited. Was it commited and you forgot to \
close the request or is still uncommited?

- Albert Astals Cid

On March 13, 2012, 4:21 a.m., Chris Smith wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/104252/
> -----------------------------------------------------------
> 
> (Updated March 13, 2012, 4:21 a.m.)
> 
> 
> Review request for KOffice.
> 
> 
> Description
> -------
> 
> Removed unused code from "kword/part/KWApplicationConfig.cpp" getting rid of make \
> warnings. 
> 
> Diffs
> -----
> 
> kword/part/KWApplicationConfig.cpp 00e2bcb 
> 
> Diff: http://git.reviewboard.kde.org/r/104252/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Chris Smith
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/104252/">http://git.reviewboard.kde.org/r/104252/</a>
  </td>
    </tr>
   </table>
   <br />

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I see this has a ship it \
but marked as uncommited. Was it commited and you forgot to close the request or is \
still uncommited?</pre>  <br />

<p>- Albert</p>

<br />
<p>On March 13th, 2012, 4:21 a.m. UTC, Chris Smith wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Chris Smith.</div>

<p style="color: grey;"><i>Updated March 13, 2012, 4:21 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Removed unused code from &quot;kword/part/KWApplicationConfig.cpp&quot; \
getting rid of make warnings.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>kword/part/KWApplicationConfig.cpp <span style="color: \
grey">(00e2bcb)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/104252/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 