'Re: Review Request: Fixed compiler warnings.'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fixed compiler warnings.
From:       "Robert Mathias Marmorstein" <robert () narnia ! homeunix ! com>
Date:       2012-03-03 15:06:52
Message-ID: 20120303150652.25678.35893 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On March 3, 2012, 3:05 p.m., Robert Mathias Marmorstein wrote:
> > Ship It!

I went ahead and applied this patch.  Thanks for the submission!

- Robert Mathias

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/103996/#review11111
-----------------------------------------------------------

On Feb. 22, 2012, 5 a.m., Richie Noble wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/103996/
> -----------------------------------------------------------
> =

> (Updated Feb. 22, 2012, 5 a.m.)
> =

> =

> Review request for KOffice, Robert Mathias Marmorstein and Thomas Zander.
> =

> =

> Description
> -------
> =

> Fixed a few simple compiler warnings in the koffice flake and kotext libr=
aries. These mostly involved removing superfluous lines of code that were p=
robably needed in earlier versions of koffice but are unused now. The bigge=
st change was made in libs/kotext/styles/KParagraphStyle.cpp where the remo=
ved lines were part of a section that was commented out to improve compatib=
ility with other office suites, specifically OpenOffice.
> =

> =

> Diffs
> -----
> =

>   libs/flake/KRTree.h 6b29017 =

>   libs/kotext/KTextBlockBorderData.cpp 58339dd =

>   libs/kotext/styles/KParagraphStyle.cpp 5377b04 =

> =

> Diff: http://git.reviewboard.kde.org/r/103996/diff/
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Richie Noble
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://git.reviewboard.kde.org/r/103996/">http://git.reviewboard.kde.org/r/103996/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On March 3rd, 2012, 3:05 p.m., <b>Robert Mathias \
Marmorstein</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ship It!</pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I went ahead and applied \
this patch.  Thanks for the submission!</pre> <br />

<p>- Robert Mathias</p>

<br />
<p>On February 22nd, 2012, 5 a.m., Richie Noble wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice, Robert Mathias Marmorstein and Thomas Zander.</div>
<div>By Richie Noble.</div>

<p style="color: grey;"><i>Updated Feb. 22, 2012, 5 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Fixed a few simple compiler warnings in the koffice flake and kotext \
libraries. These mostly involved removing superfluous lines of code that were \
probably needed in earlier versions of koffice but are unused now. The biggest change \
was made in libs/kotext/styles/KParagraphStyle.cpp where the removed lines were part \
of a section that was commented out to improve compatibility with other office \
suites, specifically OpenOffice.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>libs/flake/KRTree.h <span style="color: grey">(6b29017)</span></li>

 <li>libs/kotext/KTextBlockBorderData.cpp <span style="color: \
grey">(58339dd)</span></li>

 <li>libs/kotext/styles/KParagraphStyle.cpp <span style="color: \
grey">(5377b04)</span></li>

</ul>

<p><a href="http://git.reviewboard.kde.org/r/103996/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 