[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Support for path-stretchpoint-x and
From:       Thomas Zander <zander () kde ! org>
Date:       2011-03-27 12:56:28
Message-ID: 201103271456.28886.zander () kde ! org
[Download RAW message or body]

Hey guys,

First, thanks to Matus for the review-request, the patch looks good if you 
want to get it into koffice.git

What needs attention is that the review here is for koffice TRUNK, and since 
Inge and Casper are replying to it I'm guessing that point was not clear.
Calligra reviews go to another reviewboard and another mailinglist.

Casper and Inge choose to go to Calligra since they no longer wanted to 
work in KOffice.  And likewise KOffice people no longer are interested in Inge 
or Caspers reviews, be it on silly whitespace usage or actual serious 
coding issues.

Please pay attention to the review group in future, thanks!

On Friday 25 March 2011 12.48.27 Casper Boemann wrote:
> > On March 25, 2011, 11:36 a.m., Inge Wallin wrote:
> > > trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
> > > , line 101
> > > <http://svn.reviewboard.kde.org/r/5978/diff/1/?file=41722#file4172
> > > 2line101>
> > > 
> > >     I would actually want to register a different opinion: I think
> > >     that empty lines are underrated, and that they add to the
> > >     clarity of the code by grouping a number of statements.  In
> > >     particular, I think this empty line is fine.
> > >     
> > >     I also don't remember anything about discouraging empty lines
> > >     in the coding standards.  Can you point me to where it says
> > >     anything about it?
> 
> Well I like empty lines and use them a lot myself, so in general I
> agree
> 
> but an empty line just after a block start just seems very silly. It
> doesn't group statements, but rather makes you think it doesn't belong
> to the if clause.
> 
> 
> - Casper
> 
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5978/#review10015
> -----------------------------------------------------------
> 
> On Nov. 29, 2010, 9:48 a.m., Matus Hanzes wrote:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://svn.reviewboard.kde.org/r/5978/
> > -----------------------------------------------------------
> > 
> > (Updated Nov. 29, 2010, 9:48 a.m.)
> > 
> > 
> > Review request for KOffice.
> > 
> > 
> > Summary
> > -------
> > 
> > Path-stretchpoint-x and path-stretchpoint-y are needed for example in
> > round-rectangles to have the corners round after stretching, without
> > it the corners would be eliptical.
> > 
> > Bug 258267
> > 
> > 
> > Diffs
> > -----
> > 
> >   trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.h
> >   1201000
> >   trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cp
> >   p 1201000
> > 
> > Diff: http://svn.reviewboard.kde.org/r/5978/diff
> > 
> > 
> > Testing
> > -------
> > 
> > 
> > Thanks,
> > 
> > Matus

-- 
Thomas Zander
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]