[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Support for path-stretchpoint-x and
From: "Inge Wallin" <inge () lysator ! liu ! se>
Date: 2011-03-25 11:36:35
Message-ID: 20110325113635.12259.20422 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5978/#review10015
-----------------------------------------------------------
trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp
<http://svn.reviewboard.kde.org/r/5978/#comment11215>
I would actually want to register a different opinion: I think that emp=
ty lines are underrated, and that they add to the clarity of the code by gr=
ouping a number of statements. In particular, I think this empty line is f=
ine.
=
I also don't remember anything about discouraging empty lines in the co=
ding standards. Can you point me to where it says anything about it?
- Inge
On Nov. 29, 2010, 9:48 a.m., Matus Hanzes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5978/
> -----------------------------------------------------------
> =
> (Updated Nov. 29, 2010, 9:48 a.m.)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> Path-stretchpoint-x and path-stretchpoint-y are needed for example in rou=
nd-rectangles to have the corners round after stretching, without it the co=
rners would be eliptical.
> =
> Bug 258267
> =
> =
> Diffs
> -----
> =
> trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.h 12010=
00 =
> trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 120=
1000 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5978/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Matus
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5978/">http://svn.reviewboard.kde.org/r/5978/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5978/diff/1/?file=41722#file41722line101" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp</a> \
<span style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
EnhancedPathShape::updatePath(const QSizeF &)</pre></td> <td colspan="2"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
EnhancedPathShape::updatePath(const QSizeF & size)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">101</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I would \
actually want to register a different opinion: I think that empty lines are \
underrated, and that they add to the clarity of the code by grouping a number of \
statements. In particular, I think this empty line is fine.
I also don't remember anything about discouraging empty lines in the coding \
standards. Can you point me to where it says anything about it?</pre> </div>
<br />
<p>- Inge</p>
<br />
<p>On November 29th, 2010, 9:48 a.m., Matus Hanzes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Matus Hanzes.</div>
<p style="color: grey;"><i>Updated Nov. 29, 2010, 9:48 a.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Path-stretchpoint-x and path-stretchpoint-y are needed for example in \
round-rectangles to have the corners round after stretching, without it the corners \
would be eliptical.
Bug 258267</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.h <span \
style="color: grey">(1201000)</span></li>
<li>trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <span \
style="color: grey">(1201000)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5978/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic