Review request for KOffice and Adam Pigg.
By Jaroslaw Staniek.
Updated 2010-12-08 22:03:30
Description
For Kexi in KOffice 2.3.0.
Fix for using ICONV, and also a small fix for 'advanced options' button
possition in the import wizard.
Steps to Reproduce:
Open database with texts with encoding other than latin1.
Actual Results:
question marks replace characters
Expected Results:
proper Unicode characters in texts
The reason is that ICONV character set conversion library is not properly
linked at build time.
Also a small related fix for broken 'advanced options' button placement in the import wizard.
|
Testing
Yes, with various databases and encodings (US, PL, RU).
Expected result after applying the patch for database https://bugs.kde.org/attachment.cgi?id=54326 is here: http://imagebin.ca/view/7iPX3uOa.html
|
Diffs
- trunk/koffice/kexi/migration/importwizard.cpp (1204719)
- trunk/koffice/kexi/migration/mdb/src/CMakeLists.txt (1204719)
View Diff
|