From koffice-devel Thu Dec 09 10:02:05 2010 From: "Cyrille Berger" Date: Thu, 09 Dec 2010 10:02:05 +0000 To: koffice-devel Subject: Re: Review Request: Fix for Kexi: MS Access import does not honor Message-Id: <20101209100205.28986.14966 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=129188896513757 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1980852156==" --===============1980852156== Content-Type: multipart/alternative; boundary="===============3762455751286351034==" --===============3762455751286351034== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/6076/#review9184 ----------------------------------------------------------- Ship it! sounds ok. - Cyrille On 2010-12-08 22:03:30, Jaroslaw Staniek wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/6076/ > ----------------------------------------------------------- > = > (Updated 2010-12-08 22:03:30) > = > = > Review request for KOffice and Adam Pigg. > = > = > Summary > ------- > = > For Kexi in KOffice 2.3.0. > = > Fix for using ICONV, and also a small fix for 'advanced options' button > possition in the import wizard. > = > Steps to Reproduce: > Open database with texts with encoding other than latin1. > = > Actual Results: = > question marks replace characters > = > Expected Results: = > proper Unicode characters in texts > = > The reason is that ICONV character set conversion library is not properly > linked at build time. > = > Also a small related fix for broken 'advanced options' button placement i= n the import wizard. > = > = > This addresses bug 259259. > https://bugs.kde.org/show_bug.cgi?id=3D259259 > = > = > Diffs > ----- > = > trunk/koffice/kexi/migration/importwizard.cpp 1204719 = > trunk/koffice/kexi/migration/mdb/src/CMakeLists.txt 1204719 = > = > Diff: http://svn.reviewboard.kde.org/r/6076/diff > = > = > Testing > ------- > = > Yes, with various databases and encodings (US, PL, RU). > = > Expected result after applying the patch for database https://bugs.kde.or= g/attachment.cgi?id=3D54326 is here: http://imagebin.ca/view/7iPX3uOa.html > = > = > Thanks, > = > Jaroslaw > = > --===============3762455751286351034== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/6076/

Ship it!

sounds ok.=

- Cyrille


On December 8th, 2010, 10:03 p.m., Jaroslaw Staniek wrote:

Review request for KOffice and Adam Pigg.
By Jaroslaw Staniek.

Updated 2010-12-08 22:03:30

Descripti= on 

For Kexi in KOffice 2.3.0.

Fix for using ICONV, and also a small fix for 'advanced options' bu=
tton
possition in the import wizard.

Steps to Reproduce:
Open database with texts with encoding other than latin1.

Actual Results:  =

question marks replace characters

Expected Results:  =

proper Unicode characters in texts

The reason is that ICONV character set conversion library is not properly
linked at build time.

Also a small related fix for broken 'advanced options' button place=
ment in the import wizard.

Testing <= /h1> 
Yes, with various databases and encodings (US, PL, RU).

Expected result after applying the patch for database https://bugs.kde.org/=
attachment.cgi?id=3D54326 is here: http://imagebin.ca/view/7iPX3uOa.html
Bugs: 259259

Diffs=

  • trunk/koffice/kexi/migration/importwizard.cpp (1204719)
  • trunk/koffice/kexi/migration/mdb/src/CMakeLists.txt (1204719)

View Diff
--===============3762455751286351034==-- --===============1980852156== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1980852156==--