'Re: Review Request: Fix for Kexi: MS Access import does not honor'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix for Kexi: MS Access import does not honor
From:       "Jaroslaw Staniek" <staniek () kde ! org>
Date:       2010-12-08 22:03:31
Message-ID: 20101208220331.14322.11307 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6076/
-----------------------------------------------------------

(Updated 2010-12-08 22:03:30.992001)

Review request for KOffice and Adam Pigg.

Summary
-------

For Kexi in KOffice 2.3.0.

Fix for using ICONV, and also a small fix for 'advanced options' button
possition in the import wizard.

Steps to Reproduce:
Open database with texts with encoding other than latin1.

Actual Results:  
question marks replace characters

Expected Results:  
proper Unicode characters in texts

The reason is that ICONV character set conversion library is not properly
linked at build time.

Also a small related fix for broken 'advanced options' button placement in the import \
wizard.

This addresses bug 259259.
    https://bugs.kde.org/show_bug.cgi?id=259259

Diffs
-----

  trunk/koffice/kexi/migration/importwizard.cpp 1204719 
  trunk/koffice/kexi/migration/mdb/src/CMakeLists.txt 1204719 

Diff: http://svn.reviewboard.kde.org/r/6076/diff

Testing (updated)
-------

Yes, with various databases and encodings (US, PL, RU).

Expected result after applying the patch for database \
https://bugs.kde.org/attachment.cgi?id=54326 is here: \
http://imagebin.ca/view/7iPX3uOa.html

Thanks,

Jaroslaw

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6076/">http://svn.reviewboard.kde.org/r/6076/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice and Adam Pigg.</div>
<div>By Jaroslaw Staniek.</div>

<p style="color: grey;"><i>Updated 2010-12-08 22:03:30.992001</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For Kexi in KOffice 2.3.0.

Fix for using ICONV, and also a small fix for &#39;advanced options&#39; button
possition in the import wizard.

Steps to Reproduce:
Open database with texts with encoding other than latin1.

Actual Results:  
question marks replace characters

Expected Results:  
proper Unicode characters in texts

The reason is that ICONV character set conversion library is not properly
linked at build time.

Also a small related fix for broken &#39;advanced options&#39; button placement in \
the import wizard. </pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing \
(updated)</h1> <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Yes, with various databases and encodings (US, PL, RU).

Expected result after applying the patch for database \
https://bugs.kde.org/attachment.cgi?id=54326 is here: \
http://imagebin.ca/view/7iPX3uOa.html</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=259259">259259</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/kexi/migration/importwizard.cpp <span style="color: \
grey">(1204719)</span></li>

 <li>trunk/koffice/kexi/migration/mdb/src/CMakeLists.txt <span style="color: \
grey">(1204719)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6076/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 