[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix scaling of shape when only the resolution is
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2010-12-06 13:23:20
Message-ID: 20101206132320.25655.32171 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6050/#review9151
-----------------------------------------------------------
Ship it!
even better :-)
- Boudewijn
On 2010-12-05 21:49:08, Sven Langkamp wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/6050/
> -----------------------------------------------------------
>
> (Updated 2010-12-05 21:49:08)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> Shapes use the resolution so they need to be scaled if the image is scaled.
>
>
> This addresses bug 256135.
> https://bugs.kde.org/show_bug.cgi?id=256135
>
>
> Diffs
> -----
>
> branches/koffice/2.3/koffice/krita/image/CMakeLists.txt 1203569
> branches/koffice/2.3/koffice/krita/image/commands/kis_image_set_resolution_command.h PRE-CREATION
> branches/koffice/2.3/koffice/krita/image/commands/kis_image_set_resolution_command.cpp PRE-CREATION
> branches/koffice/2.3/koffice/krita/image/kis_image.h 1203569
> branches/koffice/2.3/koffice/krita/image/kis_image.cc 1203569
> branches/koffice/2.3/koffice/krita/image/kis_transform_visitor.h 1203569
> branches/koffice/2.3/koffice/krita/plugins/extensions/imagesize/imagesize.cc 1203569
> branches/koffice/2.3/koffice/krita/ui/kis_image_manager.h 1203569
> branches/koffice/2.3/koffice/krita/ui/kis_image_manager.cc 1203569
>
> Diff: http://svn.reviewboard.kde.org/r/6050/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Sven
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/6050/">http://svn.reviewboard.kde.org/r/6050/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">even better :-)</pre> \
<br />
<p>- Boudewijn</p>
<br />
<p>On December 5th, 2010, 9:49 p.m., Sven Langkamp wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Sven Langkamp.</div>
<p style="color: grey;"><i>Updated 2010-12-05 21:49:08</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Shapes use the resolution so they need to be scaled if the image is \
scaled.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=256135">256135</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>branches/koffice/2.3/koffice/krita/image/CMakeLists.txt <span style="color: \
grey">(1203569)</span></li>
<li>branches/koffice/2.3/koffice/krita/image/commands/kis_image_set_resolution_command.h \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/koffice/2.3/koffice/krita/image/commands/kis_image_set_resolution_command.cpp \
<span style="color: grey">(PRE-CREATION)</span></li>
<li>branches/koffice/2.3/koffice/krita/image/kis_image.h <span style="color: \
grey">(1203569)</span></li>
<li>branches/koffice/2.3/koffice/krita/image/kis_image.cc <span style="color: \
grey">(1203569)</span></li>
<li>branches/koffice/2.3/koffice/krita/image/kis_transform_visitor.h <span \
style="color: grey">(1203569)</span></li>
<li>branches/koffice/2.3/koffice/krita/plugins/extensions/imagesize/imagesize.cc \
<span style="color: grey">(1203569)</span></li>
<li>branches/koffice/2.3/koffice/krita/ui/kis_image_manager.h <span style="color: \
grey">(1203569)</span></li>
<li>branches/koffice/2.3/koffice/krita/ui/kis_image_manager.cc <span style="color: \
grey">(1203569)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/6050/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic