[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: as per koffice 2.2, item data sources should
From: Adam Pigg <piggz1 () gmail ! com>
Date: 2010-12-06 8:29:54
Message-ID: 1291624194.2255.6.camel () Nokia-N900
[Download RAW message or body]
I comitted to 2.3 already :) just check the kplato bits i did
--
Sent from my Nokia N900
On Mon, 6 Dec 2010, 08:25:05 GMT, Dag Andersen <danders@get2net.dk> wrote:
> Made a patch that includes needed changes to kplato and implements
> Jaroslaws comment.
> (I don't think Adam has much time today)
>
> Cyrrille, is this something that should go in before RC1?
>
> --
> Mvh.
> Dag Andersen
>
> Søndag 05 december 2010 21:11:08 skrev Jaroslaw Staniek:
> > -----------------------------------------------------------
> > This is an automatically generated e-mail. To reply, visit:
> > http://svn.reviewboard.kde.org/r/6055/#review9141
> > -----------------------------------------------------------
> >
> > Ship it!
> >
> >
> > To avoid broken translation I propose to wait with changing to
> > i18n("Data Source"). Other changes look good.
> >
> >
> > - Jaroslaw
> >
> > On 2010-12-05 19:51:31, Adam Pigg wrote:
> > > -----------------------------------------------------------
> > > This is an automatically generated e-mail. To reply, visit:
> > > http://svn.reviewboard.kde.org/r/6055/
> > > -----------------------------------------------------------
> > >
> > > (Updated 2010-12-05 19:51:31)
> > >
> > >
> > > Review request for KOffice.
> > >
> > >
> > > Summary
> > > -------
> > >
> > > For some reason, brances/2.2 contains a change not in trunk or
> > > -essen, that is, before the release of 2.2, when the file format of
> > > reports was reviewed, we changed the attribute for the data source
> > > of an item to report:item-data-source, from report:control-source.
> > > This patch changes branch/2.3 to match, and should be applied to
> > > trunk and -essen also.
> > >
> > > KPlato will need a small change to align to this
> > >
> > >
> > > Diffs
> > > -----
> > >
> > > branches/koffice/2.3/koffice/libs/koreport/items/check/KoReportItemChec
> > > k.cpp 1203861
> > > branches/koffice/2.3/koffice/libs/koreport/items/field/KoReportItemFie
> > > ld.cpp 1203861
> > > branches/koffice/2.3/koffice/libs/koreport/items/image/KoReportItemIma
> > > ge.cpp 1203861
> > > branches/koffice/2.3/koffice/libs/koreport/items/text/KoReportItemText
> > > .cpp 1203861
> > > branches/koffice/2.3/koffice/plugins/reporting/barcode/KoReportItemBar
> > > code.cpp 1203861
> > >
> > > Diff: http://svn.reviewboard.kde.org/r/6055/diff
> > >
> > >
> > > Testing
> > > -------
> > >
> > > I have diffed all associated files and this is the only change that
> > > needs applied.
> > >
> > >
> > > Thanks,
> > >
> > > Adam
<Attachment> reportdatasource.diff
[Attachment #3 (text/html)]
<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN" \
"http://www.w3.org/TR/html4/loose.dtd"> <html><head>
<meta http-equiv="Content-Type" content="text/html; charset=utf-8">
<meta name="generator" content="Osso Notes">
<title></title></head>
<body>
<p>I comitted to 2.3 already :) just check the kplato bits i did
<br><font color="#bdbdbd">-- </font>
<br><font color="#bdbdbd">Sent from my Nokia N900</font>
<br>
<br>On Mon,  6 Dec 2010, 08:25:05 GMT, Dag Andersen <<a \
href="mailto:danders@get2net.dk">danders@get2net.dk</a>> wrote: <br>
<br>> Made a patch that includes needed changes to kplato and implements
<br>> Jaroslaws  comment.
<br>> (I don't think Adam has much time today)
<br>>
<br>> Cyrrille, is this something that should go in before RC1?
<br>>
<br>> --
<br>> Mvh.
<br>> Dag Andersen
<br>>
<br>> Søndag 05 december 2010 21:11:08 skrev Jaroslaw Staniek:
<br>> > -----------------------------------------------------------
<br>> > This is an automatically generated e-mail. To reply, visit:
<br>> > <a href="http://svn.reviewboard.kde.org/r/6055/#review9141">http://svn.reviewboard.kde.org/r/6055/#review9141</a>
<br>> > -----------------------------------------------------------
<br>> >
<br>> > Ship it!
<br>> >
<br>> >
<br>> > To avoid broken translation I propose to wait with changing to
<br>> > i18n("Data Source"). Other changes look good.
<br>> >
<br>> >
<br>> > - Jaroslaw
<br>> >
<br>> > On 2010-12-05 19:51:31, Adam Pigg wrote:
<br>> > > -----------------------------------------------------------
<br>> > > This is an automatically generated e-mail. To reply, visit:
<br>> > > <a \
href="http://svn.reviewboard.kde.org/r/6055/">http://svn.reviewboard.kde.org/r/6055/</a>
<br>> > > -----------------------------------------------------------
<br>> > >
<br>> > > (Updated 2010-12-05 19:51:31)
<br>> > >
<br>> > >
<br>> > > Review request for KOffice.
<br>> > >
<br>> > >
<br>> > > Summary
<br>> > > -------
<br>> > >
<br>> > > For some reason, brances/2.2 contains a change not in trunk or
<br>> > > -essen, that is, before the release of 2.2, when the file format \
of <br>> > > reports was reviewed, we changed the attribute for the data \
source <br>> > > of an item to report:item-data-source, from \
report:control-source. <br>> > > This patch changes branch/2.3 to match, \
and should be applied to <br>> > > trunk and -essen also.
<br>> > >
<br>> > > KPlato will need a small change to align to this
<br>> > >
<br>> > >
<br>> > > Diffs
<br>> > > -----
<br>> > >
<br>> > > branches/koffice/2.3/koffice/libs/koreport/items/check/KoReportItemChec
<br>> > > k.cpp 1203861
<br>> > > branches/koffice/2.3/koffice/libs/koreport/items/field/KoReportItemFie
<br>> > > ld.cpp 1203861
<br>> > > branches/koffice/2.3/koffice/libs/koreport/items/image/KoReportItemIma
<br>> > > ge.cpp 1203861
<br>> > > branches/koffice/2.3/koffice/libs/koreport/items/text/KoReportItemText
<br>> > > .cpp 1203861
<br>> > > branches/koffice/2.3/koffice/plugins/reporting/barcode/KoReportItemBar
<br>> > > code.cpp 1203861
<br>> > >
<br>> > > Diff: <a \
href="http://svn.reviewboard.kde.org/r/6055/diff">http://svn.reviewboard.kde.org/r/6055/diff</a>
<br>> > >
<br>> > >
<br>> > > Testing
<br>> > > -------
<br>> > >
<br>> > > I have diffed all associated files and this is the only change \
that <br>> > > needs applied.
<br>> > >
<br>> > >
<br>> > > Thanks,
<br>> > >
<br>> > > Adam
<br>
<br><Attachment>  reportdatasource.diff
<br><br></p>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic