'Review Request: as per koffice 2.2,'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: as per koffice 2.2,
From:       "Adam Pigg" <adam () piggz ! co ! uk>
Date:       2010-12-05 19:51:31
Message-ID: 20101205195131.4015.45578 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/6055/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

For some reason, brances/2.2 contains a change not in trunk or -essen, that=
 is, before the release of 2.2, when the file format of reports was reviewe=
d, we changed the attribute for the data source of an item to report:item-d=
ata-source, from report:control-source.  This patch changes branch/2.3 to m=
atch, and should be applied to trunk and -essen also.

KPlato will need a small change to align to this

Diffs
-----

  branches/koffice/2.3/koffice/libs/koreport/items/check/KoReportItemCheck.=
cpp 1203861 =

  branches/koffice/2.3/koffice/libs/koreport/items/field/KoReportItemField.=
cpp 1203861 =

  branches/koffice/2.3/koffice/libs/koreport/items/image/KoReportItemImage.=
cpp 1203861 =

  branches/koffice/2.3/koffice/libs/koreport/items/text/KoReportItemText.cp=
p 1203861 =

  branches/koffice/2.3/koffice/plugins/reporting/barcode/KoReportItemBarcod=
e.cpp 1203861 =

Diff: http://svn.reviewboard.kde.org/r/6055/diff

Testing
-------

I have diffed all associated files and this is the only change that needs a=
pplied.

Thanks,

Adam

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/6055/">http://svn.reviewboard.kde.org/r/6055/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Adam Pigg.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">For some reason, brances/2.2 contains a change not in trunk or -essen, \
that is, before the release of 2.2, when the file format of reports was reviewed, we \
changed the attribute for the data source of an item to report:item-data-source, from \
report:control-source.  This patch changes branch/2.3 to match, and should be applied \
to trunk and -essen also.

KPlato will need a small change to align to this</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">I have diffed all associated files and this is the only change that \
needs applied.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>branches/koffice/2.3/koffice/libs/koreport/items/check/KoReportItemCheck.cpp \
<span style="color: grey">(1203861)</span></li>

 <li>branches/koffice/2.3/koffice/libs/koreport/items/field/KoReportItemField.cpp \
<span style="color: grey">(1203861)</span></li>

 <li>branches/koffice/2.3/koffice/libs/koreport/items/image/KoReportItemImage.cpp \
<span style="color: grey">(1203861)</span></li>

 <li>branches/koffice/2.3/koffice/libs/koreport/items/text/KoReportItemText.cpp <span \
style="color: grey">(1203861)</span></li>

 <li>branches/koffice/2.3/koffice/plugins/reporting/barcode/KoReportItemBarcode.cpp \
<span style="color: grey">(1203861)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/6055/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 