[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Reports: problem with pageTotal()
From:       Adam Pigg <piggz1 () gmail ! com>
Date:       2010-12-03 18:03:51
Message-ID: AANLkTimQoRbsf5dpZJ70NknaJFF77yaOOJAHWmtg7O72 () mail ! gmail ! com
[Download RAW message or body]

Looks good to me, thx, i completely forgot about it after porting to
the plugin system (that is why it was commented out)  (remember, some
pics wanted :)


On Fri, Dec 3, 2010 at 7:38 AM, Dag Andersen <danders@get2net.dk> wrote:
> Fredag 03 december 2010 07:32:27 skrev Adam Pigg:
>> Unfortunately, i didnt have a lot of time last night to look at it.
>>
>> On first glance, it seems the new code may be much slower when there
>> are lots of pages/objects, as it loops over every object in every page
>> looking for ones that require post-processing.  The old (commented)
>> code  created a list of objects requiring post-processing, as this is
>> likely to be ~no-pages.
>>
>> Could you try for something like this before the freeze, or i can have
>> a go this evening.  If not, it could go into trunk like this, as its
>> probably better working than not, and can be sped up later.
> New patch follows.
> This one registers primitives that needs post processing with the ORODocument,
> so should be as fast as possible.
>>
>> Cheers
>>
>> Adam
>>
>> On Thu, Dec 2, 2010 at 2:59 PM, Dag Andersen <danders@get2net.dk> wrote:
>> > Torsdag 02 december 2010 13:57:12 skrev Jaroslaw Staniek:
>> >> On 2 December 2010 12:58, Dag Andersen <danders@get2net.dk> wrote:
>> >> > Torsdag 02 december 2010 10:09:30 skrev Dag Andersen:
>> >> >> In kplato I define a report with fields for page number (working) and
>> >> >> total number of pages (not working). I specify control sources like
>> >> >> this: =constants.PageNumber()
>> >> >> =constants.PageTotal()
>> >> >>
>> >> >> The page total field in the generated report shows:
>> >> >> constants.PageTotal()
>> >> >>
>> >> >> Any hints?
>> >> >
>> >> > Seems this was only half finished, att patch fixes it for me.
>> >> > Could you commit if it is ok Jaroslaw?
>> >>
>> >> Would you like to review this, Adam?
>> >> Formally, is this patch suitable for applying to trunk or to essen?
>> >
>> > imvho, this is a bug as the functionallity is partially there, it just
>> > doesn't work. Thus it's a bug and should be fixed.
>> > --
>> > Mvh.
>> > Dag Andersen
>>
>> _______________________________________________
>> koffice-devel mailing list
>> koffice-devel@kde.org
>> https://mail.kde.org/mailman/listinfo/koffice-devel
>
> --
> Mvh.
> Dag Andersen
>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread]