[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Patch for the Krita Junior Job: Call the Edit >
From: "Boudewijn Rempt" <boud () valdyas ! org>
Date: 2010-11-24 14:01:52
Message-ID: 20101124140152.6287.61303 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On 2010-11-24 08:58:40, Boudewijn Rempt wrote:
> > trunk/koffice/krita/ui/kis_selection_manager.cc, line 359
> > <http://svn.reviewboard.kde.org/r/5891/diff/3/?file=41679#file41679line359>
> >
> > Sorry for being picky, but else needs to go on a new line.
>
> Francisco Fernandes wrote:
> Note taken. :) Should I fix and resend the diff?
No need, I can do that. And keep the patches coming :-). You're in Brazil, right? \
Same continent as another Krita contributor, Pentalis!
- Boudewijn
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5891/#review8951
-----------------------------------------------------------
On 2010-11-23 21:37:30, Francisco Fernandes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5891/
> -----------------------------------------------------------
>
> (Updated 2010-11-23 21:37:30)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> Patch for the Krita Junior Job: "Call the Edit > Clear action when the Del. key is \
> pressed.", in Krita Wishlist. The patch eliminate the "Delete Selection" action in \
> the "Edit" menu and merge it's function in the "Clear" action, setting the key \
> "Delete" as the shortcut.
>
> Diffs
> -----
>
> trunk/koffice/krita/ui/kis_selection_manager.cc 1199491
>
> Diff: http://svn.reviewboard.kde.org/r/5891/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Francisco
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5891/">http://svn.reviewboard.kde.org/r/5891/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On November 24th, 2010, 8:58 a.m., <b>Boudewijn \
Rempt</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5891/diff/3/?file=41679#file41679line359" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/krita/ui/kis_selection_manager.cc</a> <span \
style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KisSelectionManager::updateGUI()</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">342</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="p">}</span><span class="k">else</span> <span class="k">if</span><span \
class="p">(</span><span class="n">shapeLayer</span> <span class="o">&&</span> \
<span class="n">m_view</span><span class="o">-></span><span \
class="n">canvasBase</span><span class="p">()</span><span class="o">-></span><span \
class="n">shapeManager</span><span class="p">()</span><span \
class="o">-></span><span class="n">shapes</span><span class="p">().</span><span \
class="n">empty</span><span class="p">()){</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Sorry for being picky, \
but else needs to go on a new line.</pre> </blockquote>
<p>On November 24th, 2010, 2 p.m., <b>Francisco Fernandes</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Note taken. :) Should I \
fix and resend the diff?</pre> </blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">No need, I \
can do that. And keep the patches coming :-). You're in Brazil, right? Same \
continent as another Krita contributor, Pentalis!</pre> <br />
<p>- Boudewijn</p>
<br />
<p>On November 23rd, 2010, 9:37 p.m., Francisco Fernandes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Francisco Fernandes.</div>
<p style="color: grey;"><i>Updated 2010-11-23 21:37:30</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch for the Krita Junior Job: "Call the Edit > Clear action \
when the Del. key is pressed.", in Krita Wishlist. The patch eliminate the \
"Delete Selection" action in the "Edit" menu and merge it's \
function in the "Clear" action, setting the key "Delete" as the \
shortcut.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/krita/ui/kis_selection_manager.cc <span style="color: \
grey">(1199491)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5891/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic