'Review Request: Patch for handling of bullet sizes in kotext and'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Review Request: Patch for handling of bullet sizes in kotext and
From:       "Matus Uzak" <matus.uzak () ixonos ! com>
Date:       2010-11-22 15:20:44
Message-ID: 20101122152044.3879.74720 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5935/
-----------------------------------------------------------

Review request for KOffice.

Summary
-------

* Process the "bullet-relative-size" attribute.
* Use the QTextBlock information of the actual list item, the first one may have \
                different font size, etc.
* Do not move the bullet slightly higher by a constant, it doesn't look good at \
smaller font sizes.  

This addresses bug 247765.
    https://bugs.kde.org/show_bug.cgi?id=247765

Diffs
-----

  trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1199600 
  trunk/koffice/libs/kotext/styles/KoListStyle.h 1199600 
  trunk/koffice/plugins/textshape/Layout.cpp 1199600 

Diff: http://svn.reviewboard.kde.org/r/5935/diff

Testing
-------

On .ppt and .odp (ooimpress) files containing bulleted lists.

Thanks,

Matus

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5935/">http://svn.reviewboard.kde.org/r/5935/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Matus Uzak.</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
                break-word;">* Process the &quot;bullet-relative-size&quot; \
                attribute.
* Use the QTextBlock information of the actual list item, the first one may have \
                different font size, etc.
* Do not move the bullet slightly higher by a constant, it doesn&#39;t look good at \
smaller font sizes.  </pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">On .ppt and .odp (ooimpress) files containing bulleted lists.</pre>  \
</td>  </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="https://bugs.kde.org/show_bug.cgi?id=247765">247765</a>

</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp <span style="color: \
grey">(1199600)</span></li>

 <li>trunk/koffice/libs/kotext/styles/KoListStyle.h <span style="color: \
grey">(1199600)</span></li>

 <li>trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1199600)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5935/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 