[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Set readOnly flag correct
From: "David Faure" <faure () kde ! org>
Date: 2010-11-20 10:58:54
Message-ID: 20101120105854.30675.60284 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5910/#review8858
-----------------------------------------------------------
trunk/koffice/libs/main/KoDocument.cpp
<http://svn.reviewboard.kde.org/r/5910/#comment9489>
This will fail for remote URLs. Well it will assume writable=true, fortunately, \
so the worst that can happen is an error when saving.
The only way to make this correct for remote URLs would be to do a KIO::stat on \
the URL, which is async... OK, maybe not worth it.
I would suggest adding a comment like
// Detect readonly local-files; remote files are assumed to be writable, unless \
we add a KIO::stat here (async).
- David
On 2010-11-20 05:54:51, Thorsten Zachmann wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5910/
> -----------------------------------------------------------
>
> (Updated 2010-11-20 05:54:51)
>
>
> Review request for KOffice and David Faure.
>
>
> Summary
> -------
>
> There is a problem with displaying if a file is write protected.
>
> 1. If you load a write protected file, close it and open a non write protected file \
> it still displays that the file is write protected. 2. If you save a write \
> protected file it says the new file is write protected.
> The patch solves both problems
>
>
> Diffs
> -----
>
> trunk/koffice/libs/main/KoDocument.cpp 1197583
> trunk/koffice/libs/main/KoMainWindow.cpp 1197583
>
> Diff: http://svn.reviewboard.kde.org/r/5910/diff
>
>
> Testing
> -------
>
> Checked that the flag is correctly shown
>
>
> Thanks,
>
> Thorsten
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5910/">http://svn.reviewboard.kde.org/r/5910/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5910/diff/1/?file=41516#file41516line1265" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/main/KoDocument.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">bool \
KoDocument::openUrl(const KUrl & _url)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1265</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">KFileItem</span> <span class="n">file</span><span class="p">(</span><span \
class="n">url</span><span class="p">,</span> <span class="n">mimeType</span><span \
class="p">(),</span> <span class="n">KFileItem</span><span class="o">::</span><span \
class="n">Unknown</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This will \
fail for remote URLs. Well it will assume writable=true, fortunately, so the worst \
that can happen is an error when saving.
The only way to make this correct for remote URLs would be to do a KIO::stat on the \
URL, which is async... OK, maybe not worth it.
I would suggest adding a comment like
// Detect readonly local-files; remote files are assumed to be writable, unless we \
add a KIO::stat here (async).</pre> </div>
<br />
<p>- David</p>
<br />
<p>On November 20th, 2010, 5:54 a.m., Thorsten Zachmann wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice and David Faure.</div>
<div>By Thorsten Zachmann.</div>
<p style="color: grey;"><i>Updated 2010-11-20 05:54:51</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">There is a problem with displaying if a file is write protected.
1. If you load a write protected file, close it and open a non write protected file \
it still displays that the file is write protected. 2. If you save a write protected \
file it says the new file is write protected.
The patch solves both problems</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Checked that the flag is correctly shown</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/main/KoDocument.cpp <span style="color: \
grey">(1197583)</span></li>
<li>trunk/koffice/libs/main/KoMainWindow.cpp <span style="color: \
grey">(1197583)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5910/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic