[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Patch for the Krita Junior Job: Call the Edit >
From: "Sven Langkamp" <sven.langkamp () gmail ! com>
Date: 2010-11-17 20:48:28
Message-ID: 20101117204828.12147.95797 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5891/#review8801
-----------------------------------------------------------
I noticed a few things:
-m_delete can be completely removed
-coding style, using tabs instead of spaces
-action is enabled if an empty shape layer is active layer
-if there is a shape selection and one of the shapes is selected, the shape=
and the selected pixel are deleted
-calling two seperate slots from an action is very unusual, better merge th=
e called slots
- Sven
On 2010-11-17 19:47:26, Francisco Fernandes wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5891/
> -----------------------------------------------------------
> =
> (Updated 2010-11-17 19:47:26)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> Patch for the Krita Junior Job: "Call the Edit > Clear action when the De=
l. key is pressed.", in Krita Wishlist.
> The patch eliminate the "Delete Selection" action in the "Edit" menu and =
merge it's function in the "Clear" action,
> setting the key "Delete" as the shortcut.
> =
> =
> Diffs
> -----
> =
> trunk/koffice/krita/ui/kis_selection_manager.cc 1198182 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5891/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> Francisco
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5891/">http://svn.reviewboard.kde.org/r/5891/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I noticed a few things:
-m_delete can be completely removed
-coding style, using tabs instead of spaces
-action is enabled if an empty shape layer is active layer
-if there is a shape selection and one of the shapes is selected, the shape and the \
selected pixel are deleted
-calling two seperate slots from an action is very unusual, better merge the called \
slots</pre> <br />
<p>- Sven</p>
<br />
<p>On November 17th, 2010, 7:47 p.m., Francisco Fernandes wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Francisco Fernandes.</div>
<p style="color: grey;"><i>Updated 2010-11-17 19:47:26</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Patch for the Krita Junior Job: "Call the Edit > Clear action \
when the Del. key is pressed.", in Krita Wishlist. The patch eliminate the \
"Delete Selection" action in the "Edit" menu and merge it's \
function in the "Clear" action, setting the key "Delete" as the \
shortcut.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/krita/ui/kis_selection_manager.cc <span style="color: \
grey">(1198182)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5891/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic