[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fixed : Minimised dockers are hiding name. Bug :
From: "Thomas Zander" <zander () kde ! org>
Date: 2010-11-17 17:01:14
Message-ID: 20101117170114.6734.39356 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5868/#review8784
-----------------------------------------------------------
Hey, thanks so much for this patch. Its a very nice usability improvement :)
I also agree with Cyrille this is a good solution, except for the little detail I \
mention below.
Do you have an svn account to commit this after you verified it compiles? Otherwise \
one of the koffice guys can commit this for you. Just let us know.
/trunk/koffice/libs/widgets/KoDockWidgetTitleBar.cpp
<http://svn.reviewboard.kde.org/r/5868/#comment9405>
- Thomas
On 2010-11-16 11:30:23, Rahul Das wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5868/
> -----------------------------------------------------------
>
> (Updated 2010-11-16 11:30:23)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> Minimised dockers are hiding name and shortcut.
>
>
> This addresses bug 201160.
> https://bugs.kde.org/show_bug.cgi?id=201160
>
>
> Diffs
> -----
>
> /trunk/koffice/libs/widgets/KoDockWidgetTitleBar.cpp 1197635
>
> Diff: http://svn.reviewboard.kde.org/r/5868/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Rahul
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5868/">http://svn.reviewboard.kde.org/r/5868/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hey, thanks so much for \
this patch. Its a very nice usability improvement :)
I also agree with Cyrille this is a good solution, except for the little detail I \
mention below.
Do you have an svn account to commit this after you verified it compiles? Otherwise \
one of the koffice guys can commit this for you. Just let us know.</pre> <br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5868/diff/1/?file=41388#file41388line137" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/libs/widgets/KoDockWidgetTitleBar.cpp</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">QSize \
KoDockWidgetTitleBar::sizeHint() const</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">137</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="cm"> * /</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"></pre> \
</div> <br />
<p>- Thomas</p>
<br />
<p>On November 16th, 2010, 11:30 a.m., Rahul Das wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Rahul Das.</div>
<p style="color: grey;"><i>Updated 2010-11-16 11:30:23</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Minimised dockers are hiding name and shortcut.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=201160">201160</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/libs/widgets/KoDockWidgetTitleBar.cpp <span style="color: \
grey">(1197635)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5868/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic