'Re: Review Request: Fix for KoTextDocumentLayout hit test'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Fix for KoTextDocumentLayout hit test
From:       "Thomas Zander" <zander () kde ! org>
Date:       2010-11-17 11:23:34
Message-ID: 20101117112334.31219.33469 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

> On 2010-11-16 14:25:39, Casper Boemann wrote:
> > please see the fix for this that i've already comited to essen

Could that fix be committed in trunk?

- Thomas

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5856/#review8758
-----------------------------------------------------------

On 2010-11-16 12:23:36, Matus Hanzes wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5856/
> -----------------------------------------------------------
> =

> (Updated 2010-11-16 12:23:36)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> HitTest function in KoTextDocumentLayout is used to convert mouse pointer=
 coordinate into index of character inside QTextDocument.
> Qt::ExactHit flag means that if mouse is not over some character the func=
tion should return -1. If the mouse is over some character function should =
return the position of character.
> =

> Behavior is wrong when the mouse cursor is over QTextLine, but the text d=
oesn't start from the beginning of the QTextLine.
> In this case HitText function returns index of first character in line in=
stead of -1.
> =

> To fix it it is needed to use QTextLine::naturalTextRectangle rect instea=
d of QTextLine rect.
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp 1197331 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5856/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> Matus
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5856/">http://svn.reviewboard.kde.org/r/5856/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On November 16th, 2010, 2:25 p.m., <b>Casper \
Boemann</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">please see the fix for this that i&#39;ve already comited to essen</pre> \
</blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could that fix be \
committed in trunk?</pre> <br />

<p>- Thomas</p>

<br />
<p>On November 16th, 2010, 12:23 p.m., Matus Hanzes wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By Matus Hanzes.</div>

<p style="color: grey;"><i>Updated 2010-11-16 12:23:36</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">HitTest function in KoTextDocumentLayout is used to convert mouse \
pointer coordinate into index of character inside QTextDocument. Qt::ExactHit flag \
means that if mouse is not over some character the function should return -1. If the \
mouse is over some character function should return the position of character.

Behavior is wrong when the mouse cursor is over QTextLine, but the text doesn&#39;t \
start from the beginning of the QTextLine. In this case HitText function returns \
index of first character in line instead of -1.

To fix it it is needed to use QTextLine::naturalTextRectangle rect instead of \
QTextLine rect.

</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/kotext/KoTextDocumentLayout.cpp <span style="color: \
grey">(1197331)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5856/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 