From koffice-devel Wed Nov 10 20:51:23 2010 From: jos.van.den.oever () kogmbh ! com Date: Wed, 10 Nov 2010 20:51:23 +0000 To: koffice-devel Subject: Re: Review Request: Fix saving of mirror attributes Message-Id: <20101110205123.16496.21908 () vidsolbach ! de> X-MARC-Message: https://marc.info/?l=koffice-devel&m=128942232821135 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1097022843==" --===============1097022843== Content-Type: multipart/alternative; boundary="===============1986551470976063114==" --===============1986551470976063114== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5827/#review8645 ----------------------------------------------------------- Ship it! Nice and simple fix. Not really needed to put it up for review in my opinio= n. It looks good, but even if it's wrong, the build server will catch it. - vandenoever On 2010-11-10 19:50:10, Sven Langkamp wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5827/ > ----------------------------------------------------------- > = > (Updated 2010-11-10 19:50:10) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > Mirror attributes are saved after the element is closed which leads to in= valid odf. > = > = > Diffs > ----- > = > /trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp 11= 95298 = > = > Diff: http://svn.reviewboard.kde.org/r/5827/diff > = > = > Testing > ------- > = > Tested with oow__pyramid_diagram3.odt > = > = > Thanks, > = > Sven > = > --===============1986551470976063114== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5827/

Ship it!

Nice and s=
imple fix. Not really needed to put it up for review in my opinion. It look=
s good, but even if it's wrong, the build server will catch it.

- vandenoever

On November 10th, 2010, 7:50 p.m., Sven Langkamp wrote:

Review request for KOffice.

By Sven Langkamp.

Updated 2010-11-10 19:50:10

Descripti= on

Mirror attributes are saved after the element is closed whic=
h leads to invalid odf.

Testing <= /h1>

Tested with oow__pyramid_diagram3.odt

Diffs=

/trunk/koffice/plugins/pathshapes/enhancedpath/EnhancedPathShape.cpp <= span style=3D"color: grey">(1195298)

View Diff

--===============1986551470976063114==-- --===============1097022843== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============1097022843==--