[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Fix OpenGL texture boundaries
From: Lukáš Tvrdý <lukast.dev () gmail ! com>
Date: 2010-11-06 22:24:08
Message-ID: 20101106222408.29890.52035 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5778/#review8526
-----------------------------------------------------------
Ship it!
I think you are awesome.
I did not test, I just reviewed the code style a bit.
/trunk/koffice/krita/ui/opengl/kis_opengl_image_textures.h
<http://svn.reviewboard.kde.org/r/5778/#comment8887>
Is this typedef really needed? Just personal feeling, ignore if you want :)
/trunk/koffice/krita/ui/opengl/kis_texture_tile.h
<http://svn.reviewboard.kde.org/r/5778/#comment8888>
no qDegug(), please
/trunk/koffice/krita/ui/opengl/kis_texture_tile.h
<http://svn.reviewboard.kde.org/r/5778/#comment8889>
qDebug again
/trunk/koffice/krita/ui/opengl/kis_texture_tile_update_info.h
<http://svn.reviewboard.kde.org/r/5778/#comment8890>
qDebug again
- Lukáš
On 2010-11-06 18:54:26, Dmitry Kazakov wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5778/
> -----------------------------------------------------------
>
> (Updated 2010-11-06 18:54:26)
>
>
> Review request for KOffice.
>
>
> Summary
> -------
>
> This is a fix for the bug 251113. It fixes both of the issues: border-effect on the \
> boundaries of the textures and the effect on the image->bound(). It creates an \
> abstraction for a texture tile (KisTextureTile). I need some testing now.
>
>
> This addresses bug 251113.
> https://bugs.kde.org/show_bug.cgi?id=251113
>
>
> Diffs
> -----
>
> /trunk/koffice/krita/ui/opengl/kis_opengl_canvas2.cpp 1193131
> /trunk/koffice/krita/ui/opengl/kis_opengl_image_textures.h 1193131
> /trunk/koffice/krita/ui/opengl/kis_opengl_image_textures.cpp 1193131
> /trunk/koffice/krita/ui/opengl/kis_texture_tile.h PRE-CREATION
> /trunk/koffice/krita/ui/opengl/kis_texture_tile_update_info.h 1193131
>
> Diff: http://svn.reviewboard.kde.org/r/5778/diff
>
>
> Testing
> -------
>
>
> Thanks,
>
> Dmitry
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5778/">http://svn.reviewboard.kde.org/r/5778/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I think you are awesome.
I did not test, I just reviewed the code style a bit.
</pre>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5778/diff/1/?file=40680#file40680line221" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/krita/ui/opengl/kis_opengl_image_textures.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">private:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">171</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">typedef</span> <span class="n">QMap</span><span class="o"><</span><span \
class="n">KisImageWSP</span><span class="p">,</span> <span \
class="n">KisOpenGLImageTextures</span><span class="o">*></span> <span \
class="n">ImageTexturesMap</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Is this \
typedef really needed? Just personal feeling, ignore if you want :)</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5778/diff/1/?file=40682#file40682line92" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/krita/ui/opengl/kis_texture_tile.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">92</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">qDebug</span><span class="p">()</span> <span \
class="o"><<</span> <span class="s">"Writing texture"</span> <span \
class="o"><<</span> <span class="n">ppVar</span><span class="p">(</span><span \
class="n">m_textureRectInImagePixels</span><span class="p">)</span> <span \
class="o"><<</span><span class="n">ppVar</span><span class="p">(</span><span \
class="n">updateInfo</span><span class="p">.</span><span \
class="n">patchOffset</span><span class="p">())</span> <span \
class="o"><<</span> <span class="n">ppVar</span><span class="p">(</span><span \
class="n">updateInfo</span><span class="p">.</span><span \
class="n">patchSize</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">no \
qDegug(), please</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5778/diff/1/?file=40682#file40682line103" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/krita/ui/opengl/kis_texture_tile.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
"></pre></td> <td colspan="2"><pre style="font-size: 8pt; line-height: 140%; margin: \
0; ">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">103</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">qDebug</span><span class="p">()</span> <span \
class="o"><<</span> <span class="s">"Writing texture"</span> <span \
class="o"><<</span> <span class="n">ppVar</span><span class="p">(</span><span \
class="n">m_textureRectInImagePixels</span><span class="p">)</span> <span \
class="o"><<</span><span class="n">ppVar</span><span class="p">(</span><span \
class="n">updateInfo</span><span class="p">.</span><span \
class="n">patchOffset</span><span class="p">())</span> <span \
class="o"><<</span> <span class="n">ppVar</span><span class="p">(</span><span \
class="n">updateInfo</span><span class="p">.</span><span \
class="n">patchSize</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">qDebug \
again</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="http://svn.reviewboard.kde.org/r/5778/diff/1/?file=40683#file40683line57" \
style="color: black; font-weight: bold; text-decoration: \
underline;">/trunk/koffice/krita/ui/opengl/kis_texture_tile_update_info.h</a> <span \
style="font-weight: normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">54</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">m_patchPixels</span> <span class="o">=</span> <span \
class="n">m_patchColorSpace</span><span class="o">-></span><span \
class="n">allocPixelBuffer</span><span class="p">(</span><span \
class="n">m_patchRect</span><span class="p">.</span><span class="n">width</span><span \
class="p">()</span> <span class="o">*</span> <span class="n">m_patchRect</span><span \
class="p">.</span><span class="n">height</span><span class="p">()</span><span \
class="o">*</span><span class="mi">2</span><span class="p">);</span></pre></td> <th \
bgcolor="#e9eaa8" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">57</font></th> <td bgcolor="#fdfebc" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">qDebug</span><span class="p">()</span> <span class="o"><<</span> \
<span class="s">"Retrieving data:"</span> <span class="o"><<</span> \
<span class="n">m_patchRect</span><span class="p">;</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">qDebug \
again</pre> </div>
<br />
<p>- Lukáš</p>
<br />
<p>On November 6th, 2010, 6:54 p.m., Dmitry Kazakov wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By Dmitry Kazakov.</div>
<p style="color: grey;"><i>Updated 2010-11-06 18:54:26</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This is a fix for the bug 251113. It fixes both of the issues: \
border-effect on the boundaries of the textures and the effect on the \
image->bound(). It creates an abstraction for a texture tile (KisTextureTile).
I need some testing now.</pre>
</td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="https://bugs.kde.org/show_bug.cgi?id=251113">251113</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>/trunk/koffice/krita/ui/opengl/kis_opengl_canvas2.cpp <span style="color: \
grey">(1193131)</span></li>
<li>/trunk/koffice/krita/ui/opengl/kis_opengl_image_textures.h <span style="color: \
grey">(1193131)</span></li>
<li>/trunk/koffice/krita/ui/opengl/kis_opengl_image_textures.cpp <span style="color: \
grey">(1193131)</span></li>
<li>/trunk/koffice/krita/ui/opengl/kis_texture_tile.h <span style="color: \
grey">(PRE-CREATION)</span></li>
<li>/trunk/koffice/krita/ui/opengl/kis_texture_tile_update_info.h <span \
style="color: grey">(1193131)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5778/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic