--===============0661396482== Content-Type: multipart/alternative; boundary="===============4047064617728102916==" --===============4047064617728102916== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5743/#review8465 ----------------------------------------------------------- trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp In many places the saving code has been rewritten to not use 'contains'= anymore but instead check that the object that comes out is valid. (i.e. = QColor::isValid()) = Maybe thats a strategy to follow for new code too? :) - Thomas On 2010-11-01 13:56:21, nandita suri wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5743/ > ----------------------------------------------------------- > = > (Updated 2010-11-01 13:56:21) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > * style:text-properties and fo:color element are saved/written in saveOdf= () of KoListLevelProperties.cpp = > This saves the color of the bullet back in open document format. > = > = > Diffs > ----- > = > trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1191936 = > = > Diff: http://svn.reviewboard.kde.org/r/5743/diff > = > = > Testing > ------- > = > = > Thanks, > = > nandita > = > --===============4047064617728102916== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5743/

= =

trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp (Diff revision 1)
void KoListLevelProperties::saveOdf(KoXmlWriter *writer) const
		613	if (d->stylesPrivate.= contains(KoListStyle::BulletColor))

In many places the saving code has been rewritten to not use 'co=
ntains' anymore but instead check that the object that comes out is val=
id.  (i.e. QColor::isValid())

Maybe thats a strategy to follow for new code too? :)

- Thomas

On November 1st, 2010, 1:56 p.m., nandita suri wrote:

Review request for KOffice.

By nandita suri.

Updated 2010-11-01 13:56:21

Descripti= on

* style:text-properties and fo:color element are saved/writt=
en in saveOdf() of KoListLevelProperties.cpp =

This saves the color of the bullet back in open document format.

Diffs=

trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp (1191936)

View Diff

--===============4047064617728102916==-- --===============0661396482== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0661396482==--