This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5726/ |
On October 29th, 2010, 8:21 a.m., Johannes Simon wrote:
Generally I like the idea of having a central class to save an ODF table. KChart would need one, too, btw, it is currently done in ChartShape.cpp, which is obviously the wrong place. I have two remarks regarding your approach: 1) Why not also make it load a table? It is, after all, a very related task. 2) Interesting for the chart shape would be an interface (or adapter) to use your classes to purely save/load an existing QAbstractTableModel. Note that there's no style information attached to its internal table. Maybe instead it would also be possible to use QAbstractTableModel as the handler for actual data, and have an API around it to add styles to rows, columns and cells.
1) I think that the main porpuse of the ODF library we try to provide at KOffice is for writing ODFs rather than load them. This could be added in the future, though. 2) Do note that you don't have to add a style, if you don't it'll write a mere table to the file. A KoAbstractTableModelWriter could be developed for your use case. That way the responsibilities are also very well separated.
- Carlos
On October 29th, 2010, 3:09 a.m., Carlos Licea wrote:
Review request for KOffice and Casper Boemann.
By Carlos Licea.
Updated 2010-10-29 03:09:40 Description
Testing
Diffs
|