--===============0464487834== Content-Type: multipart/alternative; boundary="===============4323044047471558097==" --===============4323044047471558097== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5726/ ----------------------------------------------------------- Review request for KOffice and Casper Boemann. Summary ------- Warning: Mildly-Long description ahead. >Rationale Currently we need to save a table in at less 3 different parts: * The TableShape (TODO as of now) * The PPTX filter * The DOCX filter (We could include The KSpread table but I don't know if KSpread would like = to outsource the saving of its file format.) So far we have had different implementations, everyone with slightly differ= ent behavior and different quirks and bugs. For this reason I've decided to= create a "centralized" way to save a table. Originally I started this work in the MSOOXML filters, then moved it to a n= ew library but then I realized that the best place was libs/odf. >Work done The patch introduces several classes that map to the ODF concepts. So far I= 'm mildly satisfied with the results, I think the API promises but it's sti= ll a long way from complete. >Remarks >> General There are a few remarks I'd like to point out: * Give a through review to the API, I want it to be as stable as possible s= o that I can continue building on it. * There's going to be a naming clash between KWord's KoTableStyle and the o= ne proposed here. I propose renaming KWord's as this class is more generic,= plus it is meant to be be a public API for our ODF library. A namespace co= uld also be added (Ko)ODF. * I added a KoStyle class. As I said, I intended this to be a new library b= efore realizing that it should go to the ODF library. I did, however left i= t as it allows less look-ups of the name in the KoGenStyles. * Somebody might ask why I added a KoTableProperties, I didn't want to clut= ter the KoTable API with so many properties when its behavior is much more = important. * I still haven't added the export macro to the classes as it's on another = one of my branches. * Tests are coming. * Documentation is also coming, I have some of it in a branch but I haven't= heavily invested in it as I still consider this a work in progress. * Adaptation in the MsooXml filters is also comming, not released again bec= ause of unstable API. >>Implementation specific * KoTable is the owner of all the KoCell's, KoRow's and KoColumn's. There's= no way to create one of those outside the Table. * KoCellValue maps to office:value and its linked attributes. * KoCellChild on the other hand represents all the different children of a = Cell in the table:table-cell. I intend it to be expanded over time to cover= many more children so that they also can be created using a nice API. Diffs ----- branches/work/koffice-essen/libs/odf/CMakeLists.txt 1186909 = branches/work/koffice-essen/libs/odf/KoCell.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoCell.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoCellChild.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoCellChild.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoCellStyle.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoCellStyle.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoCellValue.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoCellValue.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoColumn.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoColumn.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoColumnStyle.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoDummyCellValue.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoDummyCellValue.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoRawCellChild.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoRawCellChild.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoRow.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoRow.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoRowStyle.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoStyle.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoStyle.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoTable.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoTable.cpp PRE-CREATION = branches/work/koffice-essen/libs/odf/KoTableProperties.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoTableStyle.h PRE-CREATION = branches/work/koffice-essen/libs/odf/KoTableTemplate.h PRE-CREATION = Diff: http://svn.reviewboard.kde.org/r/5726/diff Testing ------- As I said tests are coming too. Thanks, Carlos --===============4323044047471558097== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5726/

Review request for KOffice and Casper Boemann.
By Carlos Licea.

Descripti= on 

Warning: Mildly-Long description ahead.

>Rationale
Currently we need to save a table in at less 3 different parts:
* The TableShape (TODO as of now)
* The PPTX filter
* The DOCX filter
(We could include The KSpread table but I don't know if KSpread would l=
ike to outsource the saving of its file format.)

So far we have had different implementations, everyone with slightly differ=
ent behavior and different quirks and bugs. For this reason I've decide=
d to create a "centralized" way to save a table.
Originally I started this work in the MSOOXML filters, then moved it to a n=
ew library but then I realized that the best place was libs/odf.

>Work done
The patch introduces several classes that map to the ODF concepts. So far I=
'm mildly satisfied with the results, I think the API promises but it&#=
39;s still a long way from complete.

>Remarks
>> General
There are a few remarks I'd like to point out:
* Give a through review to the API, I want it to be as stable as possible s=
o that I can continue building on it.
* There's going to be a naming clash between KWord's KoTableStyle a=
nd the one proposed here. I propose renaming KWord's as this class is m=
ore generic, plus it is meant to be be a public API for our ODF library. A =
namespace could also be added (Ko)ODF.
* I added a KoStyle class. As I said, I intended this to be a new library b=
efore realizing that it should go to the ODF library. I did, however left i=
t as it allows less look-ups of the name in the KoGenStyles.
* Somebody might ask why I added a KoTableProperties, I didn't want to =
clutter the KoTable API with so many properties when its behavior is much m=
ore important.
* I still haven't added the export macro to the classes as it's on =
another one of my branches.
* Tests are coming.
* Documentation is also coming, I have some of it in a branch but I haven&#=
39;t heavily invested in it as I still consider this a work in progress.
* Adaptation in the MsooXml filters is also comming, not released again bec=
ause of unstable API.

>>Implementation specific
* KoTable is the owner of all the KoCell's, KoRow's and KoColumn=
9;s. There's no way to create one of those outside the Table.
* KoCellValue maps to office:value and its linked attributes.
* KoCellChild on the other hand represents all the different children of a =
Cell in the table:table-cell. I intend it to be expanded over time to cover=
 many more children so that they also can be created using a nice API.

Testing <= /h1> 
As I said tests are coming too.

Diffs=

  • branches/work/koffice-essen/libs/odf/CMakeLists.txt (1186909)
  • branches/work/koffice-essen/libs/odf/KoCell.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoCell.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoCellChild.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoCellChild.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoCellStyle.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoCellStyle.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoCellValue.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoCellValue.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoColumn.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoColumn.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoColumnStyle.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoDummyCellValue.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoDummyCellValue.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoRawCellChild.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoRawCellChild.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoRow.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoRow.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoRowStyle.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoStyle.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoStyle.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoTable.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoTable.cpp (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoTableProperties.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoTableStyle.h (PRE-CREATION)
  • branches/work/koffice-essen/libs/odf/KoTableTemplate.h (PRE-CREATION)

View Diff
--===============4323044047471558097==-- --===============0464487834== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0464487834==--