[prev in list] [next in list] [prev in thread] [next in thread]
List: koffice-devel
Subject: Re: Review Request: Handling bullet color in kotext and textshape
From: "Pierre Ducroquet" <pinaraf () pinaraf ! info>
Date: 2010-10-28 12:25:44
Message-ID: 20101028122544.28656.28832 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5701/#review8408
-----------------------------------------------------------
Ship it!
It seems to be all right now, I'm going to commit it.
- Pierre
On 2010-10-28 12:21:24, nandita suri wrote:
> =
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5701/
> -----------------------------------------------------------
> =
> (Updated 2010-10-28 12:21:24)
> =
> =
> Review request for KOffice.
> =
> =
> Summary
> -------
> =
> * Handling fo:color in loadOdf() of libs/kotext/styles/KoListLevelPropert=
ies.cpp
> * Defined a new property called BulletColor in the list of bullet propert=
ies in libs/kotext/styles/KoListStyle.h
> * Rendering the color of the bullet in Layout::drawListItem() of plugins/=
textshape/Layout.cpp
> * If color of the bullet is not defined, default color black is used
> =
> =
> Diffs
> -----
> =
> trunk/koffice/libs/kotext/styles/KoListLevelProperties.h 1190637 =
> trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1190637 =
> trunk/koffice/libs/kotext/styles/KoListStyle.h 1190637 =
> trunk/koffice/plugins/textshape/Layout.cpp 1190637 =
> =
> Diff: http://svn.reviewboard.kde.org/r/5701/diff
> =
> =
> Testing
> -------
> =
> =
> Thanks,
> =
> nandita
> =
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://svn.reviewboard.kde.org/r/5701/">http://svn.reviewboard.kde.org/r/5701/</a>
</td>
</tr>
</table>
<br />
<p>Ship it!</p>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It seems to be all right \
now, I'm going to commit it.</pre> <br />
<p>- Pierre</p>
<br />
<p>On October 28th, 2010, 12:21 p.m., nandita suri wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KOffice.</div>
<div>By nandita suri.</div>
<p style="color: grey;"><i>Updated 2010-10-28 12:21:24</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Handling fo:color in loadOdf() of \
libs/kotext/styles/KoListLevelProperties.cpp
* Defined a new property called BulletColor in the list of bullet properties in \
libs/kotext/styles/KoListStyle.h
* Rendering the color of the bullet in Layout::drawListItem() of \
plugins/textshape/Layout.cpp
* If color of the bullet is not defined, default color black is used</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>trunk/koffice/libs/kotext/styles/KoListLevelProperties.h <span style="color: \
grey">(1190637)</span></li>
<li>trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp <span style="color: \
grey">(1190637)</span></li>
<li>trunk/koffice/libs/kotext/styles/KoListStyle.h <span style="color: \
grey">(1190637)</span></li>
<li>trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1190637)</span></li>
</ul>
<p><a href="http://svn.reviewboard.kde.org/r/5701/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic