'Re: Review Request: Handling bullet color in kotext and textshape'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       koffice-devel
Subject:    Re: Review Request: Handling bullet color in kotext and textshape
From:       "Pierre Ducroquet" <pinaraf () pinaraf ! info>
Date:       2010-10-27 20:22:41
Message-ID: 20101027202241.9226.74759 () vidsolbach ! de
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://svn.reviewboard.kde.org/r/5701/#review8402
-----------------------------------------------------------

trunk/koffice/libs/kotext/styles/KoListLevelProperties.h
<http://svn.reviewboard.kde.org/r/5701/#comment8721>

    Why is this a QString ? It must be a QColor, for safety and consistency=
... It would also remove time spent creating QColors when applying the styl=
e.

trunk/koffice/libs/kotext/styles/KoListStyle.h
<http://svn.reviewboard.kde.org/r/5701/#comment8722>

    For binary compatibility, shouldn't this be added at the bottom of the =
enum ?

trunk/koffice/plugins/textshape/Layout.cpp
<http://svn.reviewboard.kde.org/r/5701/#comment8724>

    Be careful : does the following painter calls reset the pen ? To be sur=
e, you should perhaps save/restore the painter state here.

trunk/koffice/plugins/textshape/Layout.cpp
<http://svn.reviewboard.kde.org/r/5701/#comment8723>

    This should be Qt::black, not QColor("black"). Converting from a static=
 string to QColor dynamically is useless...

- Pierre

On 2010-10-27 15:49:24, nandita suri wrote:
> =

> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://svn.reviewboard.kde.org/r/5701/
> -----------------------------------------------------------
> =

> (Updated 2010-10-27 15:49:24)
> =

> =

> Review request for KOffice.
> =

> =

> Summary
> -------
> =

> * Handling fo:color in loadOdf() of libs/kotext/styles/KoListLevelPropert=
ies.cpp
> * Defined a new property called BulletColor in the list of bullet propert=
ies in libs/kotext/styles/KoListStyle.h
> * Rendering the color of the bullet in Layout::drawListItem() of plugins/=
textshape/Layout.cpp
> * If color of the bullet is not defined, default color black is used
> =

> =

> Diffs
> -----
> =

>   trunk/koffice/libs/kotext/styles/KoListLevelProperties.h 1190420 =

>   trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp 1190420 =

>   trunk/koffice/libs/kotext/styles/KoListStyle.h 1190420 =

>   trunk/koffice/plugins/textshape/Layout.cpp 1190420 =

> =

> Diff: http://svn.reviewboard.kde.org/r/5701/diff
> =

> =

> Testing
> -------
> =

> =

> Thanks,
> =

> nandita
> =

>

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="http://svn.reviewboard.kde.org/r/5701/">http://svn.reviewboard.kde.org/r/5701/</a>
  </td>
    </tr>
   </table>
   <br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/5701/diff/1/?file=40323#file40323line86" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/kotext/styles/KoListLevelProperties.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">86</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">    <span \
class="kt">void</span> <span class="n">setBulletColor</span><span \
class="p">(</span><span class="n">QString</span> <span class="n">color</span><span \
class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Why is this \
a QString ? It must be a QColor, for safety and consistency... It would also remove \
time spent creating QColors when applying the style.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/5701/diff/1/?file=40325#file40325line129" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/libs/kotext/styles/KoListStyle.h</a>  <span \
style="font-weight: normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">public:</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">129</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">        <span \
class="n">BulletColor</span><span class="p">,</span>    <span class="c1">///&lt; \
color of the counter</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">For binary \
compatibility, shouldn&#39;t this be added at the bottom of the enum ?</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/5701/diff/1/?file=40326#file40326line1782" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/plugins/textshape/Layout.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Layout::drawListItem(QPainter *painter, const QTextBlock &amp;block, \
KoImageCollection *imageCollection)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1782</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">painter</span><span class="o">-&gt;</span><span \
class="n">setPen</span><span class="p">(</span><span class="n">QPen</span><span \
class="p">(</span><span class="n">color</span><span class="p">));</span></pre></td>  \
</tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Be careful \
: does the following painter calls reset the pen ? To be sure, you should perhaps \
save/restore the painter state here.</pre> </div>
<br />

<div>

<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;">  <thead>
  <tr>
   <th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;">  <a \
href="http://svn.reviewboard.kde.org/r/5701/diff/1/?file=40326#file40326line1785" \
style="color: black; font-weight: bold; text-decoration: \
underline;">trunk/koffice/plugins/textshape/Layout.cpp</a>  <span style="font-weight: \
normal;">

     (Diff revision 1)

    </span>
   </th>
  </tr>
 </thead>

 <tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
  <tr>

   <td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
Layout::drawListItem(QPainter *painter, const QTextBlock &amp;block, \
KoImageCollection *imageCollection)</pre></td>

  </tr>
 </tbody>

 <tbody>

  <tr>
    <th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th>  <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td>  <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">1785</font></th>  <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">              \
<span class="n">color</span> <span class="o">=</span> <span \
class="n">QColor</span><span class="p">(</span><span \
class="s">&quot;black&quot;</span><span class="p">);</span></pre></td>  </tr>

 </tbody>

</table>

<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">This should \
be Qt::black, not QColor(&quot;black&quot;). Converting from a static string to \
QColor dynamically is useless...</pre> </div>
<br />

<p>- Pierre</p>

<br />
<p>On October 27th, 2010, 3:49 p.m., nandita suri wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://svn.reviewboard.kde.orgrb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KOffice.</div>
<div>By nandita suri.</div>

<p style="color: grey;"><i>Updated 2010-10-27 15:49:24</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">* Handling fo:color in loadOdf() of \
                libs/kotext/styles/KoListLevelProperties.cpp
* Defined a new property called BulletColor in the list of bullet properties in \
                libs/kotext/styles/KoListStyle.h
* Rendering the color of the bullet in Layout::drawListItem() of \
                plugins/textshape/Layout.cpp
* If color of the bullet is not defined, default color black is used</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>trunk/koffice/libs/kotext/styles/KoListLevelProperties.h <span style="color: \
grey">(1190420)</span></li>

 <li>trunk/koffice/libs/kotext/styles/KoListLevelProperties.cpp <span style="color: \
grey">(1190420)</span></li>

 <li>trunk/koffice/libs/kotext/styles/KoListStyle.h <span style="color: \
grey">(1190420)</span></li>

 <li>trunk/koffice/plugins/textshape/Layout.cpp <span style="color: \
grey">(1190420)</span></li>

</ul>

<p><a href="http://svn.reviewboard.kde.org/r/5701/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
koffice-devel mailing list
koffice-devel@kde.org
https://mail.kde.org/mailman/listinfo/koffice-devel

[prev in list] [next in list] [prev in thread] [next in thread] 