--===============0657921145== Content-Type: multipart/alternative; boundary="===============3046533055410083244==" --===============3046533055410083244== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5610/#review8398 ----------------------------------------------------------- /trunk/koffice/libs/main/KoView.h I would like to suggest to name this method createPdfPrintJob() - Thomas On 2010-10-26 21:01:05, Benjamin Port wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://svn.reviewboard.kde.org/r/5610/ > ----------------------------------------------------------- > = > (Updated 2010-10-26 21:01:05) > = > = > Review request for KOffice. > = > = > Summary > ------- > = > BUG:241245 > This patch correct the bug 214245, when we export to pdf in KPresenter, n= ow the page size is slide size. > With the new methods to export to pdf, each KOffice application can choos= e to kept the old export feature (just print), or implement a specific oper= ation for export pdf. > = > = > Diffs > ----- > = > /trunk/koffice/kpresenter/part/CMakeLists.txt 1190045 = > /trunk/koffice/kpresenter/part/KPrPdfPrintJob.h PRE-CREATION = > /trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp PRE-CREATION = > /trunk/koffice/kpresenter/part/KPrView.h 1190045 = > /trunk/koffice/kpresenter/part/KPrView.cpp 1190045 = > /trunk/koffice/libs/kopageapp/KoPAPrintJob.h 1190045 = > /trunk/koffice/libs/main/KoMainWindow.cpp 1190045 = > /trunk/koffice/libs/main/KoView.h 1190045 = > /trunk/koffice/libs/main/KoView.cpp 1190045 = > = > Diff: http://svn.reviewboard.kde.org/r/5610/diff > = > = > Testing > ------- > = > = > Thanks, > = > Benjamin > = > --===============3046533055410083244== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable

This is an automatically generated e-mail. To reply, visit: http://svn.reviewb= oard.kde.org/r/5610/

= =

/trunk/koffice/libs/main/KoView.h (Diff revision 3)
public:
		203	virtual KoPrintJob * cre= ateExportPdf();

I would like to suggest to name this method
  createPdfPrintJob()

- Thomas

On October 26th, 2010, 9:01 p.m., Benjamin Port wrote:

Review request for KOffice.

By Benjamin Port.

Updated 2010-10-26 21:01:05

Descripti= on

BUG:241245
This patch correct the bug 214245, when we export to pdf in KPresenter, now=
 the page size is slide size.
With the new methods to export to pdf, each KOffice application can choose =
to kept the old export feature (just print), or implement a specific operat=
ion for export pdf.

Diffs=

/trunk/koffice/kpresenter/part/CMakeLists.txt (1190045)
/trunk/koffice/kpresenter/part/KPrPdfPrintJob.h (PRE-CREATION)
/trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp (PRE-CREATION)
/trunk/koffice/kpresenter/part/KPrView.h (= 1190045)
/trunk/koffice/kpresenter/part/KPrView.cpp (1190045)
/trunk/koffice/libs/kopageapp/KoPAPrintJob.h (1190045)
/trunk/koffice/libs/main/KoMainWindow.cpp = (1190045)
/trunk/koffice/libs/main/KoView.h (1190045= )
/trunk/koffice/libs/main/KoView.cpp (11900= 45)

--===============3046533055410083244==-- --===============0657921145== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ koffice-devel mailing list koffice-devel@kde.org https://mail.kde.org/mailman/listinfo/koffice-devel --===============0657921145==--