This is an automatically generated e-mail. To reply, visit: http://svn.reviewboard.kde.org/r/5610/

/trunk/koffice/libs/main/KoView.h (Diff revision 3)
public:
203
    virtual KoPrintJob * createExportPdf();
I would like to suggest to name this method
  createPdfPrintJob()

- Thomas


On October 26th, 2010, 9:01 p.m., Benjamin Port wrote:

Review request for KOffice.
By Benjamin Port.

Updated 2010-10-26 21:01:05

Description

BUG:241245
This patch correct the bug 214245, when we export to pdf in KPresenter, now the page size is slide size.
With the new methods to export to pdf, each KOffice application can choose to kept the old export feature (just print), or implement a specific operation for export pdf.

Diffs

  • /trunk/koffice/kpresenter/part/CMakeLists.txt (1190045)
  • /trunk/koffice/kpresenter/part/KPrPdfPrintJob.h (PRE-CREATION)
  • /trunk/koffice/kpresenter/part/KPrPdfPrintJob.cpp (PRE-CREATION)
  • /trunk/koffice/kpresenter/part/KPrView.h (1190045)
  • /trunk/koffice/kpresenter/part/KPrView.cpp (1190045)
  • /trunk/koffice/libs/kopageapp/KoPAPrintJob.h (1190045)
  • /trunk/koffice/libs/main/KoMainWindow.cpp (1190045)
  • /trunk/koffice/libs/main/KoView.h (1190045)
  • /trunk/koffice/libs/main/KoView.cpp (1190045)

View Diff